Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coderd): add dbcrypt package#9522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 12 commits intomainfromcj/dbcrypt_redux_1
Sep 6, 2023
Merged

feat(coderd): add dbcrypt package#9522

johnstcn merged 12 commits intomainfromcj/dbcrypt_redux_1
Sep 6, 2023

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedSep 4, 2023•
edited
Loading

Reimplementation of#9421 following comments.

  • Adds package enterprise/dbcrypt to implement database encryption/decryption
  • Adds table dbcrypt_keys and associated queries
  • Adds columns oauth_access_token_key_id and oauth_refresh_token_key_id to tables git_auth_links and user_links

NOTE: This is part 1 of a 2-part PR. This PR focuses mainly on the dbcrypt and database packages. A separate PR will add the required plumbing to integrate this into enterprise/coderd properly.

Part 2:#9523

- Adds package enterprise/dbcrypt to implement database encryption/decryption- Adds table dbcrypt_keys and associated queries- Adds columns oauth_access_token_key_id and oauth_refresh_token_key_id  to tables git_auth_links and user_linksNOTE: This is part 1 of a 2-part PR. This PR focusesmainly on the dbcrypt and database packages. A separatePR will add the required plumbing to integrate this intoenterprise/coderd properly.Co-authored-by: Kyle Carberry <kyle@coder.com>
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I went through the code, and it looks fine to me. I believe that you can proceed with a follow-up.

johnstcn reacted with thumbs up emoji
@johnstcnjohnstcn marked this pull request as ready for reviewSeptember 5, 2023 09:11
@johnstcnjohnstcn merged commit7918e65 intomainSep 6, 2023
@johnstcnjohnstcn deleted the cj/dbcrypt_redux_1 branchSeptember 6, 2023 11:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 6, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@spikecurtisspikecurtisspikecurtis left review comments

@deansheatherdeansheatherdeansheather left review comments

@mtojekmtojekmtojek approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@johnstcn@spikecurtis@deansheather@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp