Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: addCODER_TLS_ADDRESS to documentation for TLS setup#9503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 8 commits intocoder:mainfromvoxnyx:patch-1
Sep 5, 2023

Conversation

voxnyx
Copy link
Contributor

Updated TLS instructions to include CODER_TLS_ADDRESS

Updated TLS instructions to include CODER_TLS_ADDRESS
@cdr-botcdr-botbot added the communityPull Requests and issues created by the community. labelSep 4, 2023
@github-actions
Copy link

github-actionsbot commentedSep 4, 2023•
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@voxnyx
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull requestSep 4, 2023
@matifalimatifali changed the titleAdd CODER_TLS_ADDRESS to documentation for TLS Setup.docs: addCODER_TLS_ADDRESS to documentation for TLS setupSep 4, 2023
@matifali
Copy link
Member

@RaineAllDay Thanks for the contribution.

ericpaulsen
ericpaulsen previously requested changesSep 4, 2023
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM@ericpaulsen can you give another look. I changed all references to 127.0.0.1 with 0.0.0.0 and linked to our reverse proxy docs at the bottom.

@matifali
Copy link
Member

@bpmct and@ericpaulsen thoughts on movinghttps://github.com/RaineAllDay/coder/tree/main/examples/web-server todocs/admin directory?

@matifalimatifali added the docsArea: coder.com/docs labelSep 5, 2023
bpmct
bpmct previously requested changesSep 5, 2023
Copy link
Member

@bpmctbpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the contribution! However, I believe we already link to this in our configure docs.https://coder.com/docs/v2/latest/admin/configure#tls--reverse-proxy.

Also I noticed a typo:revres and the link goes to your personal repo not the Coder official one.

@bpmct
Copy link
Member

bpmct commentedSep 5, 2023•
edited
Loading

@bpmct and@ericpaulsen thoughts on movinghttps://github.com/coder/coder/tree/main/examples/web-server todocs/admin directory?

I would be open to this, but I think the main thing is we link to these from our official docs, just like example templates.

matifali reacted with thumbs up emoji

@matifalimatifali requested a review frombpmctSeptember 5, 2023 13:35
@matifali
Copy link
Member

@bpmct The OP only suggested to mentionCODER_TLS_ADDRESS. I did the rest of the refactoring. Thanks for pointing out the that docs url was pointing to OP's fork. It is fixed now.

@matifalimatifalienabled auto-merge (squash)September 5, 2023 13:59
@matifalimatifali dismissed stale reviews frombpmct andericpaulsenSeptember 5, 2023 19:05

outdated

@matifalimatifalienabled auto-merge (squash)September 5, 2023 19:06
@matifalimatifali merged commitd85c354 intocoder:mainSep 5, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@ericpaulsenericpaulsenAwaiting requested review from ericpaulsen

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@voxnyxvoxnyx

Labels
communityPull Requests and issues created by the community.docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@voxnyx@matifali@bpmct@ericpaulsen
[8]ページ先頭
©2009-2025 Movatter.jp