Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Improve resource preview and first-time experience#946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 21 commits intomainfromclihelp
Apr 11, 2022

Conversation

kylecarbs
Copy link
Member

  • Adds resource preview table.
  • Reorganizes prompts on workspace create.
  • Improves english in various places.

asciicast

This enables a "kubernetes_pod" to attach multiple agents thatcould be for multiple services. Each agent is required to havea unique name, so SSH syntax is:`coder ssh <workspace>.<agent>`A resource can have zero agents too, they aren't required.
This enables a "kubernetes_pod" to attach multiple agents thatcould be for multiple services. Each agent is required to havea unique name, so SSH syntax is:`coder ssh <workspace>.<agent>`A resource can have zero agents too, they aren't required.
This command was `true` by default, which causesa confusing user experience.
@kylecarbskylecarbs self-assigned thisApr 10, 2022
@kylecarbskylecarbs requested a review froma team as acode ownerApril 10, 2022 21:12
@codecov
Copy link

codecovbot commentedApr 10, 2022•
edited
Loading

Codecov Report

Merging#946 (683f87e) intomain (19b4323) willincrease coverage by0.54%.
The diff coverage is60.94%.

@@            Coverage Diff             @@##             main     #946      +/-   ##==========================================+ Coverage   66.22%   66.76%   +0.54%==========================================  Files         240      241       +1       Lines       14408    14582     +174       Branches      115      115              ==========================================+ Hits         9542     9736     +194+ Misses       3904     3864      -40- Partials      962      982      +20
FlagCoverage Δ
unittest-go-macos-latest53.72% <60.42%> (+0.96%)⬆️
unittest-go-postgres-66.51% <60.94%> (+0.60%)⬆️
unittest-go-ubuntu-latest56.38% <60.42%> (+1.03%)⬆️
unittest-go-windows-202253.01% <60.42%> (+0.96%)⬆️
unittest-js61.56% <ø> (ø)
Impacted FilesCoverage Δ
cli/cliui/cliui.go40.00% <ø> (ø)
cli/cliui/select.go58.82% <0.00%> (-2.41%)⬇️
cli/templatelist.go10.00% <0.00%> (+1.30%)⬆️
cli/templates.go100.00% <ø> (+45.76%)⬆️
cli/templateupdate.go7.24% <0.00%> (ø)
cli/workspacedelete.go26.08% <0.00%> (+8.43%)⬆️
cli/workspacelist.go7.01% <0.00%> (-2.51%)⬇️
codersdk/workspaceresources.go45.45% <ø> (ø)
cli/workspaceshow.go20.00% <11.76%> (-30.00%)⬇️
coderd/workspaceagents.go58.66% <22.22%> (-9.73%)⬇️
... and35 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update19b4323...683f87e. Read thecomment docs.

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

site/ changes LGTM ✔️

@@ -17,7 +17,7 @@ const config: PlaywrightTestConfig = {
// https://playwright.dev/docs/test-advanced#launching-a-development-web-server-during-the-tests
webServer: {
// Run the coder daemon directly.
command: `go run -tags embed ${path.join(__dirname, "../../cmd/coder/main.go")} start --dev --tunnel=false`,
command: `go run -tags embed ${path.join(__dirname, "../../cmd/coder/main.go")} start --dev --skip-tunnel`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 LGTM

kylecarbs reacted with hooray emoji
Base automatically changed fromupdatetfprovider tomainApril 11, 2022 21:06
@@ -100,6 +100,10 @@ func (a *agent) run(ctx context.Context) {
}

func (a *agent) handlePeerConn(ctx context.Context, conn *peer.Conn) {
go func() {
<-a.closed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It feels strange to be doing this in one goroutine and waiting forconn.Closed() in another goroutine, just to callDone(). Can we not do it in one?

kylecarbs reacted with thumbs up emoji
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
@kylecarbskylecarbsforce-pushed theclihelp branch 2 times, most recently fromc3ba120 to5f2d858CompareApril 11, 2022 22:43
@kylecarbskylecarbsforce-pushed theclihelp branch 2 times, most recently from00a9994 to421dd0eCompareApril 11, 2022 23:23
@kylecarbskylecarbsenabled auto-merge (squash)April 11, 2022 23:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled left review comments

@johnstcnjohnstcnjohnstcn approved these changes

@f0sself0sselAwaiting requested review from f0ssel

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@johnstcn@greyscaled
[8]ページ先頭
©2009-2025 Movatter.jp