- Notifications
You must be signed in to change notification settings - Fork928
test(site): improve E2E framework#9438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mtojek commentedAug 30, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@BrunoQuaresma Do you have an idea why is npm failing here? I can see occurrences like this: EDIT: Oh it looks like I forgot to commit this file... |
| @@ -554,7 +554,7 @@ jobs: | |||
| - run: pnpm playwright:install | |||
| working-directory: site | |||
| - run: pnpm playwright:test | |||
| - run: pnpm playwright:test --workers 1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why are we setting workers to1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you delete this, playwright will run tests in parallel, and it may cause the Coder backend overloaded.
I want to reduce the amount of points that can break e2e tests. Additionally, our e2e tests are relatively quick, so if it isn't a problem I would disable parallelism for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice addition
Uh oh!
There was an error while loading.Please reload this page.
This PR adds more debugging hooks to Chromium events, so that we can intercept HTTP calls, and simply log them.
Changes: