NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

feat: Allow workspace resources to attach multiple agents#942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kylecarbs merged 1 commit intomainfromupdatetfprovider

Apr 11, 2022

Merged

feat: Allow workspace resources to attach multiple agents#942

kylecarbs merged 1 commit intomainfromupdatetfprovider

Apr 11, 2022

Conversation

Copy link

Member

kylecarbs commentedApr 9, 2022

This enables a "kubernetes_pod" to attach multiple agents that
could be for multiple services. Each agent is required to have
a unique name, so SSH syntax is:

coder ssh <workspace>.<agent>

A resource can have zero agents too, they aren't required.

kylecarbs requested review fromcoadler andf0ssel

April 9, 2022 01:03

Copy link

codecovbot commentedApr 9, 2022•
edited
Loading

Codecov Report

Merging#942 (3ad0766) intomain (38f0742) willdecrease coverage by0.09%.
The diff coverage is62.91%.

@@            Coverage Diff             @@##             main     #942      +/-   ##==========================================- Coverage   65.78%   65.68%   -0.10%==========================================  Files         226      228       +2       Lines       13991    14178     +187       Branches      105      105              ==========================================+ Hits         9204     9313     +109- Misses       3848     3909      +61- Partials      939      956      +17

Flag	Coverage Δ
unittest-go-macos-latest	`52.60% <42.55%> (-0.37%)`	⬇️
unittest-go-postgres-	`65.48% <62.31%> (-0.17%)`	⬇️
unittest-go-ubuntu-latest	`55.27% <54.25%> (+0.02%)`	⬆️
unittest-go-windows-2022	`51.70% <42.24%> (-0.47%)`	⬇️
unittest-js	`58.25% <ø> (ø)`

Impacted Files	Coverage Δ
cli/templates.go	`54.23% <0.00%> (ø)`
cli/workspaceshow.go	`50.00% <ø> (+35.71%)`	⬆️
codersdk/workspaceresources.go	`45.45% <ø> (-11.54%)`	⬇️
cli/configssh.go	`54.86% <6.25%> (-3.17%)`	⬇️
coderd/httpmw/workspaceagentparam.go	`30.88% <30.88%> (ø)`
cli/ssh.go	`38.88% <42.85%> (-0.96%)`	⬇️
coderd/workspaceresources.go	`28.94% <50.00%> (-32.03%)`	⬇️
coderd/provisionerjobs.go	`63.43% <55.55%> (+1.50%)`	⬆️
codersdk/workspaceagents.go	`52.60% <57.89%> (ø)`
coderd/workspaceagents.go	`66.98% <66.98%> (ø)`
... and23 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update38f0742...3ad0766. Read thecomment docs.

kylecarbs force-pushed theupdatetfprovider branch 6 times, most recently frome8258ea to0682aa6Compare

April 9, 2022 18:43

feat: Allow workspace resources to attach multiple agents

3ad0766

This enables a "kubernetes_pod" to attach multiple agents thatcould be for multiple services. Each agent is required to havea unique name, so SSH syntax is:`coder ssh <workspace>.<agent>`A resource can have zero agents too, they aren't required.

kylecarbs force-pushed theupdatetfprovider branch from0682aa6 to3ad0766Compare

April 10, 2022 15:52

kylecarbs self-assigned this

Apr 10, 2022