- Notifications
You must be signed in to change notification settings - Fork928
feat(cli): add DataDog Go tracer#9411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should already be getting this info from prometheus btw, unless dd's APM thingy is better. We also are already using the default exporter to export to the dd agent so make sure to disable that on dogfood so it's not sending twice.
Uh oh!
There was an error while loading.Please reload this page.
coderd/tracing/exporter.go Outdated
| if opts.DataDog { | ||
| // See more: | ||
| // https://docs.datadoghq.com/tracing/metrics/runtime_metrics/go/ | ||
| dd := ddotel.NewTracerProvider() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think you need something like this to actually enable runtime metrics, according to your link
import ddtracer"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"dd:=ddotel.NewTracerProvider(ddtracer.WithRuntimeMetrics())
| @@ -24,7 +26,8 @@ type TracerOpts struct { | |||
| Default bool | |||
| // Coder exports traces to Coder's public tracing ingest service and is used | |||
| // to improve the product. It is disabled when opting out of telemetry. | |||
| Coder bool | |||
| Coder bool | |||
| DataDog bool | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should add a comment
@coadler - is there a place is datadog where the Go runtime information (e.g. goroutines) is already being reported? I couldn't find it. |
3111e6d to3547b0eCompareAdded the profiler as well. |
feat(cli): add DataDog Go tracer