Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: fix coder template pull on Windows#9327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 4 commits intomainfromspike/9291-template-pull-windows
Aug 25, 2023

Conversation

spikecurtis
Copy link
Contributor

fixes#9291 and adds a unit test

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis
Copy link
ContributorAuthor

Unfortunately, extracting the tests out of at.Run() subtest structure breaks the diff on GitHub. But, the new test can't be run in parallel, so it can't be a subtest...

mtojek reacted with thumbs up emoji

Signed-off-by: Spike Curtis <spike@coder.com>
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 as along as CI is happy

@mafredri
Copy link
Member

Unfortunately, extracting the tests out of at.Run() subtest structure breaks the diff on GitHub. But, the new test can't be run in parallel, so it can't be a subtest...

Using the hide whitespace feature made it quite alright 👌

spikecurtis reacted with hooray emoji

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtisspikecurtisenabled auto-merge (squash)August 25, 2023 08:49
@github-actions
Copy link

github-actionsbot commentedAug 25, 2023•
edited
Loading

✔️ PR 9327 Created successfully.
🚀 Access the credentialshere.

cc:@matifali

github-actions[bot] reacted with rocket emoji

@matifali
Copy link
Member

Tested here seems to resolve the issue.

PS C:\Users\matif\Downloads> .\coder_test.exe login https://pr9327.test.cdr.dev/Your browser has been opened to visit:        https://pr9327.test.cdr.dev/cli-auth> Paste your token here:> Welcome to Coder, coder! You're authenticated.PS C:\Users\matif\Downloads> .\coder_test.exe templates lsNAME        LAST UPDATED     USED BYkubernetes  August 25, 2023  - active developersPS C:\Users\matif\Downloads> .\coder_test.exe templates pull kubernetesExtracting template to "kubernetes"PS C:\Users\matif\Downloads> ls .\kubernetes\    Directory: C:\Users\matif\Downloads\kubernetesMode                 LastWriteTime         Length Name----                 -------------         ------ -----a---          25/08/2023 12:16 pm           2489 .terraform.lock.hcl-a---          25/08/2023 12:16 pm           8147 main.tf

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

tested in a PR deployment and seems to resolve the issue.

@spikecurtisspikecurtis merged commitaed891b intomainAug 25, 2023
@spikecurtisspikecurtis deleted the spike/9291-template-pull-windows branchAugust 25, 2023 10:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 25, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

@matifalimatifalimatifali approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@spikecurtisspikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

coder templates pull does not work as expected on Windows

5 participants

@spikecurtis@mafredri@matifali@johnstcn@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp