Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update aws_linux template#9325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 3 commits intomainfrommatifali/aws-linux-template
Aug 25, 2023
Merged

Conversation

matifali
Copy link
Member

@matifalimatifali commentedAug 25, 2023•
edited
Loading

Updated the template with the following changes

  1. Useec2_instance_state to manage start/stop.
  2. Update agent metadata to usecoder stat.
  3. Update some wrong regional flag emojis.
  4. Updated Coder terraform provider.

Please test athttps://dev.coder.com/templates/aws-linux.

Closes#8931

Updated the template with the following changes1. usehttps://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ec2_instance_state.html to manage start/stop2. Update agent metadata to use `coder stat`3. Update some wrong regional flag emojis
@matifalimatifali requested a review frombpmctAugust 25, 2023 06:44
@matifalimatifali self-assigned thisAug 25, 2023
@github-actions
Copy link

github-actionsbot commentedAug 25, 2023•
edited
Loading

✔️ PR 9325 Created successfully.
🚀 Access the credentialshere.

cc:@matifali

github-actions[bot] reacted with rocket emoji

Copy link
Member

@bpmctbpmct left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey, this looks good! Some feedback:

  • Changecount of the agent to 0 or 1 based on the transition state so that the agent isn't flashing when the workspace is stopped
    Screenshot 2023-08-25 at 8 12 21 AM
  • Remove comment that mentions user data and just have local.user_data instead of conditionally rendering it

matifali reacted with thumbs up emoji
bpmct

This comment was marked as duplicate.

@matifalimatifalienabled auto-merge (squash)August 25, 2023 13:48
@matifalimatifali merged commit3b1ecd3 intomainAug 25, 2023
@matifalimatifali deleted the matifali/aws-linux-template branchAugust 25, 2023 13:50
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 25, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bpmctbpmctbpmct approved these changes

Assignees

@matifalimatifali

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change AWS examples to useaws_ec2_instance_state

2 participants

@matifali@bpmct
[8]ページ先頭
©2009-2025 Movatter.jp