Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(site): make workspace batch deletion GA#9313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 10 commits intomainfrombq/make-batch-action-ga
Aug 30, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

Copy link
Member

@bpmctbpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! We're making this an enterprise feature, right? If so, can you also update the enterprise docs:https://coder.com/docs/v2/latest/enterprise and add a basic section on the workspaces page?

@BrunoQuaresma
Copy link
CollaboratorAuthor

@bpmct good call!

@matifali
Copy link
Member

Don't you think we should add other actions star/stop/restart/update before making it GA?
Or we should call itbatch deletion.

Another issue is it can't delete failed workspaces and that is currently not possible from the dashboard.

@bpmct
Copy link
Member

(just testing the deploy PR haha, not actually reviewing the functionality)

@github-actions
Copy link

github-actionsbot commentedAug 25, 2023
edited
Loading


✔️ PR 9313 Created successfully.
🚀 Access the credentialshere.

cc:@bpmct

github-actions[bot] reacted with rocket emoji

@matifalimatifali changed the titlefeat(site): make workspace batch actions GAfeat(site): make workspace batch deletion GAAug 28, 2023
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am ok with this. I have one feedback that you are free to disregard.
Can we hide the check boxes by default?
Similar to how Gmail does this?
Showing empty check boxes all the time is taking extra space.

@BrunoQuaresma
Copy link
CollaboratorAuthor

@matifali for me, it is always displayed, otherwise how could the user select the workspace? 🤔
Screen Shot 2023-08-30 at 10 06 59

@BrunoQuaresmaBrunoQuaresma merged commit2399063 intomainAug 30, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/make-batch-action-ga branchAugust 30, 2023 13:08
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 30, 2023
@matifali
Copy link
Member

Sorry, just ignore this. Thank you for showing me.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

@matifalimatifalimatifali approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@BrunoQuaresma@matifali@bpmct@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp