- Notifications
You must be signed in to change notification settings - Fork928
fix: separate dev shell and dev image nix deps#9189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
| @@ -153,6 +159,13 @@ | |||
| experimental-features = nix-command flakes | |||
| '' | |||
| ) | |||
| # Allow people to change shells! | |||
| ( | |||
| pkgs.writeTextDir "etc/shells" '' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Need slash?
| pkgs.writeTextDir"etc/shells"'' | |
| pkgs.writeTextDir"/etc/shells"'' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nah, it adds that automatically
No description provided.