Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add update profile endpoint#916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 16 commits intomainfrombq/users-crud
Apr 12, 2022
Merged

feat: Add update profile endpoint#916

BrunoQuaresma merged 16 commits intomainfrombq/users-crud
Apr 12, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedApr 7, 2022•
edited
Loading

Related to#975

@codercoder deleted a comment fromcodecovbotApr 7, 2022
@codecov
Copy link

codecovbot commentedApr 7, 2022•
edited
Loading

Codecov Report

Merging#916 (4531e0d) intomain (313b51d) willincrease coverage by0.03%.
The diff coverage is80.21%.

@@            Coverage Diff             @@##             main     #916      +/-   ##==========================================+ Coverage   65.85%   65.88%   +0.03%==========================================  Files         218      216       -2       Lines       13849    13919      +70       Branches      103      103              ==========================================+ Hits         9120     9171      +51- Misses       3803     3813      +10- Partials      926      935       +9
FlagCoverage Δ
unittest-go-macos-latest?
unittest-go-postgres-65.62% <80.21%> (-0.09%)⬇️
unittest-go-ubuntu-latest55.43% <57.14%> (+0.19%)⬆️
unittest-go-windows-202252.30% <57.14%> (+0.08%)⬆️
unittest-js59.09% <ø> (ø)
Impacted FilesCoverage Δ
codersdk/users.go65.86% <72.72%> (+0.48%)⬆️
coderd/users.go58.58% <74.13%> (+1.18%)⬆️
coderd/coderd.go96.89% <100.00%> (+0.01%)⬆️
coderd/database/queries.sql.go84.00% <100.00%> (+0.24%)⬆️
provisionersdk/transport.go78.72% <0.00%> (-6.39%)⬇️
codersdk/provisionerdaemons.go58.46% <0.00%> (-6.16%)⬇️
coderd/workspaceresources.go56.09% <0.00%> (-4.88%)⬇️
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
provisionerd/provisionerd.go78.56% <0.00%> (-1.18%)⬇️
coderd/provisionerdaemons.go61.55% <0.00%> (-0.51%)⬇️
... and6 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update313b51d...4531e0d. Read thecomment docs.

@BrunoQuaresma
Copy link
CollaboratorAuthor

I ranmake fmt but the style job stills failing 🤔

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left 1 comment on the name field. We should use the existing name field if the new name field is"" ornil

@BrunoQuaresmaBrunoQuaresma changed the titlefeat: Add PATCH /users/{user} endpointfeat: Add profile endpointApr 12, 2022
@BrunoQuaresmaBrunoQuaresma changed the titlefeat: Add profile endpointfeat: Add update profile endpointApr 12, 2022
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me!

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)April 12, 2022 13:52
@BrunoQuaresmaBrunoQuaresma merged commit63d1465 intomainApr 12, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/users-crud branchApril 12, 2022 14:05
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@f0sself0sselAwaiting requested review from f0ssel

@EmyrkEmyrkAwaiting requested review from Emyrk

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

5 participants
@BrunoQuaresma@Emyrk@kylecarbs@f0ssel@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp