- Notifications
You must be signed in to change notification settings - Fork920
fix: fix CI concurrency#9088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
.github/workflows/ci.yaml Outdated
| @@ -20,7 +20,7 @@ permissions: | |||
| # additional changes | |||
| concurrency: | |||
| group: ${{ github.workflow }}-${{ github.ref }} | |||
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} | |||
| cancel-in-progress: ${{ github.event_name == 'push' }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Will this cancel pushes on themain branch too? I would expect us to want all pushes to be fully tested there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes you are right. It will also cancel onmain. May be we should revert#9017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@mafredri Or I can update the condition to ignoremain
This fixes concurrency issues which was inadvertently introduced in#9017