NotificationsYou must be signed in to change notification settings
Fork913
Star10k

feat: add header-process flag#9059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

code-asher merged 3 commits intomainfromasher/header-process

Aug 14, 2023

Merged

feat: add header-process flag#9059

code-asher merged 3 commits intomainfromasher/header-process

Aug 14, 2023

Conversation

Copy link

Member

code-asher commentedAug 11, 2023

This allows specifying a command to run that can output headers for cases where users require dynamic headers (like to authenticate to their VPN).

The primary use case is to add this flag in SSH configs created by the VS Code plugin, although maybe config-ssh should do the same.

This is required to completecoder/vscode-coder#119, which in turn is meant toclosecoder/vscode-coder#76.

github-actionsbot assignedcode-asher

Aug 11, 2023

code-asher changed the title~~Add header-process flag~~feat: add header-process flag

Aug 11, 2023

code-asher force-pushed theasher/header-process branch 5 times, most recently fromc763cee to538d2fcCompare

August 11, 2023 23:28

Add header-process flag

bccc2d6

This allows specifying a command to run that can output headers forcases where users require dynamic headers (like to authenticate to theirVPN).The primary use case is to add this flag in SSH configs created by theVS Code plugin, although maybe config-ssh should do the same.

code-asher force-pushed theasher/header-process branch from538d2fc tobccc2d6Compare

August 11, 2023 23:36

code-asher marked this pull request as ready for review

August 11, 2023 23:55

code-asher requested a review fromdeansheather

August 11, 2023 23:56

Copy link

MemberAuthor

code-asher commentedAug 11, 2023•
edited
Loading

@kylecarbs just fyi I went with--header-process. If anyone has different name ideas I would love to hear them! Or if anyone thinks this should be more generic to potentially supply more than just headers in the future.