- Notifications
You must be signed in to change notification settings - Fork928
chore: configure chromatic snapshot tests#896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Resolves:#444Summary:This commit installs and configures a GH action for chromatic. Chromaticis used for snapshot testing build-over-build.Details:* chore(site): install chromatic* chore(site): add chromatic package.json scriptSuggested by the docs for convenience so that we can run chromatic like:```consoleyarn run chromatic ...```* chore: gitignore storybook builds* ci: configure chromaticThis action configures chromatic to run in CI on pushes to all branches.By running this in CI, we get the following:- snapshot (build-over-build)- checks in our CIThe snapshots and build-over-build behavior are per branch; this way wecan work on a feature branch without worrying about changes being madeto mainline independently.
codecovbot commentedApr 6, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #896 +/- ##==========================================+ Coverage 65.77% 65.96% +0.18%========================================== Files 216 216 Lines 13734 13734 Branches 103 103 ==========================================+ Hits 9033 9059 +26+ Misses 3782 3761 -21+ Partials 919 914 -5
Continue to review full report at Codecov.
|
This is now the responsibility of Chromatic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I tried to fix this with the semantic config, but I'd prefer if we kept the syntax simple and stopped using(). I think a more explicit ending message helps reads interpret a consistent format.
I'd like to enforce this with CI, but I did a bad job haha!
Something like:chore: configure Chromatic snapshot tests
Updated PR title, I'll ensure I squash with the same title! Thanks for identifying this, I agree we can omit scopes for now. |
@presleyp and@BrunoQuaresma I'm merging this right now because it will help us with the current in-flight PRs that add storybook rather than later. |
This is an oversight from#896 . It turns out that because we use the GitHub integration with Chromatic, we don't need to wait for the results to be reported in the action - they get reported in the other checks created by Chromatic.This option was spit-out in a check:https://github.com/coder/coder/runs/5859427236?check_suite_focus=true#step:4:38Relates to#444
This is an oversight from#896 . It turns out that because we use the GitHub integration with Chromatic, we don't need to wait for the results to be reported in the action - they get reported in the other checks created by Chromatic.This option was spit-out in a check:https://github.com/coder/coder/runs/5859427236?check_suite_focus=true#step:4:38Relates to#444
Resolves:#444
Summary
This commit installs and configures a GH action for chromatic. Chromatic
is used for snapshot testing build-over-build.
Details
chore(site): install chromatic
chore(site): add chromatic package.json script
Suggested by the docs for convenience so that we can run chromatic like:
yarn run chromatic ...chore: gitignore storybook builds
ci: configure chromatic
This action configures chromatic to run in CI on pushes to all branches.
By running this in CI, we get the following:
The snapshots and build-over-build behavior are per branch; this way we
can work on a feature branch without worrying about changes being made
to mainline independently.
Impact
This is largely an internal workflow chore, it has no user/product-facing impact.