Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: rename .yml to .yaml#895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jsjoeio merged 2 commits intomainfromjsjoeio/fix-yml
Apr 6, 2022
Merged

chore: rename .yml to .yaml#895

jsjoeio merged 2 commits intomainfromjsjoeio/fix-yml
Apr 6, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeiojsjoeio commentedApr 6, 2022•
edited
Loading

I noticed an inconsistency in our choice of.yml vs.yaml. Based on feedback from the team, I chose to rename all files to use.yaml.

This means we'll keep it consistent in the codebase.

@jsjoeiojsjoeio self-assigned thisApr 6, 2022
@jsjoeiojsjoeio requested a review froma team as acode ownerApril 6, 2022 20:32
@codecov
Copy link

codecovbot commentedApr 6, 2022•
edited
Loading

Codecov Report

Merging#895 (cf6afb6) intomain (fe23dcd) willincrease coverage by0.05%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main     #895      +/-   ##==========================================+ Coverage   65.77%   65.82%   +0.05%==========================================  Files         216      123      -93       Lines       13734    12570    -1164       Branches      103        0     -103     ==========================================- Hits         9033     8274     -759+ Misses       3782     3406     -376+ Partials      919      890      -29
FlagCoverage Δ
unittest-go-65.20% <ø> (-0.35%)⬇️
unittest-go-macos-latest52.80% <ø> (-0.20%)⬇️
unittest-go-ubuntu-latest55.27% <ø> (-0.08%)⬇️
unittest-go-windows-2022?
unittest-js?
Impacted FilesCoverage Δ
cli/configssh.go50.00% <0.00%> (-8.04%)⬇️
provisionersdk/transport.go78.72% <0.00%> (-6.39%)⬇️
coderd/workspaceresources.go54.87% <0.00%> (-5.70%)⬇️
cli/cliui/agent.go77.19% <0.00%> (-5.27%)⬇️
pty/ptytest/ptytest.go89.65% <0.00%> (-5.18%)⬇️
cli/templateinit.go56.36% <0.00%> (-3.64%)⬇️
peer/conn.go77.91% <0.00%> (-3.05%)⬇️
peer/channel.go83.04% <0.00%> (-2.93%)⬇️
provisioner/echo/serve.go56.80% <0.00%> (-2.41%)⬇️
provisionerd/provisionerd.go79.14% <0.00%> (-1.62%)⬇️
... and96 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatefe23dcd...cf6afb6. Read thecomment docs.

@code-asher
Copy link
Member

Oh yeah, we went with.yaml because that is the official extension. IMO that means we should stick with.yaml.

jsjoeio reacted with thumbs up emoji

@code-asher
Copy link
Member

I should clarify by "we" I meant code-server, I got confused which repo I was on. I would still vote for.yaml here though!

jsjoeio reacted with laugh emoji

@kylecarbs
Copy link
Member

I'm also a vote for.yaml!.yml doesn't read properly IMO

jsjoeio and greyscaled reacted with thumbs up emoji

@jsjoeio
Copy link
ContributorAuthor

Sounds good to me. I was hoping y'all wanted that. I prefer.yaml too. I'll make the change!

greyscaled reacted with thumbs up emojicode-asher reacted with hooray emoji

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love the consistency!

jsjoeio reacted with heart emoji
@jsjoeiojsjoeioenabled auto-merge (squash)April 6, 2022 21:29
@jsjoeiojsjoeio merged commiteefca43 intomainApr 6, 2022
@jsjoeiojsjoeio deleted the jsjoeio/fix-yml branchApril 6, 2022 21:33
@greyscaledgreyscaled changed the titlechore: rename .yaml to .ymlchore: rename .yml to .yamlApr 6, 2022
@greyscaled
Copy link
Contributor

@jsjoeio I updated the title post-merge. We might want to double check the commit that was pushed to mainline, since it might accidentally convey the opposite 😂.

@jsjoeio
Copy link
ContributorAuthor

Oh no! I completely forgot to change 🤦🏼‍♂️@vapurrmaid nice catch

@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@code-ashercode-ashercode-asher approved these changes

Assignees

@jsjoeiojsjoeio

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

5 participants
@jsjoeio@code-asher@kylecarbs@greyscaled@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp