Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add preferences pages#893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 11 commits intomainfrombq/preferences-page
Apr 7, 2022
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedApr 6, 2022•
edited
Loading

  • Rename Panel to TabPanel to make it clear it is a "tabbed" panel
  • Move Sidebar to TabPanel/TabSidebar since it is only used inside of TabPanel
  • Updated sidebar to use NavLink instead of onClick events

Closes#746

@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerApril 6, 2022 19:10
@BrunoQuaresma
Copy link
CollaboratorAuthor

BrunoQuaresma commentedApr 6, 2022•
edited
Loading

@presleyp this may impact your work with the admin pages. Please, let me know if it breaks anything for you.

@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 6, 2022
@codecov
Copy link

codecovbot commentedApr 6, 2022•
edited
Loading

Codecov Report

Merging#893 (86a1d7a) intomain (90388a3) willincrease coverage by0.15%.
The diff coverage is0.00%.

@@            Coverage Diff             @@##             main     #893      +/-   ##==========================================+ Coverage   65.73%   65.88%   +0.15%==========================================  Files         218      222       +4       Lines       13849    13875      +26       Branches      103      103              ==========================================+ Hits         9103     9142      +39+ Misses       3814     3811       -3+ Partials      932      922      -10
FlagCoverage Δ
unittest-go-macos-latest52.92% <ø> (+0.02%)⬆️
unittest-go-postgres-65.83% <ø> (+0.40%)⬆️
unittest-go-ubuntu-latest55.30% <ø> (-0.12%)⬇️
unittest-go-windows-202252.18% <ø> (+0.01%)⬆️
unittest-js57.59% <0.00%> (-1.51%)⬇️
Impacted FilesCoverage Δ
site/src/AppRouter.tsx0.00% <0.00%> (ø)
site/src/components/Preferences/Layout.tsx0.00% <0.00%> (ø)
site/src/components/TabPanel/TabSidebar.tsx0.00% <0.00%> (ø)
site/src/components/TabPanel/index.tsx0.00% <0.00%> (ø)
site/src/pages/preferences/account.tsx0.00% <0.00%> (ø)
site/src/pages/preferences/linked-accounts.tsx0.00% <0.00%> (ø)
site/src/pages/preferences/security.tsx0.00% <0.00%> (ø)
site/src/pages/preferences/ssh-keys.tsx0.00% <0.00%> (ø)
pty/start_other.go64.70% <0.00%> (-23.53%)⬇️
provisionerd/provisionerd.go80.46% <0.00%> (-0.59%)⬇️
... and10 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update90388a3...86a1d7a. Read thecomment docs.

Copy link
Contributor

@presleyppresleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! Can you take all the user-facing strings and put them inLanguage objects? There's an example in the SignInForm I believe.

greyscaled reacted with thumbs up emoji
Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you merge latest main into this branch so that we get the Chromatic workflow to run

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you merge latest mainline again --> want to have chromatic rerun on this one and it will error if your branch is behind#910

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Last set of changes, everything looks great otherwise!

@BrunoQuaresmaBrunoQuaresma merged commit75ef1f4 intomainApr 7, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/preferences-page branchApril 7, 2022 19:44
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@presleyppresleyppresleyp approved these changes

@greyscaledgreyscaledgreyscaled approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

User Preferences page
4 participants
@BrunoQuaresma@presleyp@greyscaled@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp