Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add user menu#887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 8 commits intomainfrombq/usermenu
Apr 7, 2022
Merged

feat: Add user menu#887

BrunoQuaresma merged 8 commits intomainfrombq/usermenu
Apr 7, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes#743

@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerApril 6, 2022 16:01
@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 6, 2022
@codecov
Copy link

codecovbot commentedApr 6, 2022•
edited
Loading

Codecov Report

Merging#887 (d17a808) intomain (23f9891) willdecrease coverage by0.55%.
The diff coverage is46.66%.

@@            Coverage Diff             @@##             main     #887      +/-   ##==========================================- Coverage   66.54%   65.99%   -0.56%==========================================  Files         126      218      +92       Lines       12854    13849     +995       Branches        0      103     +103     ==========================================+ Hits         8554     9139     +585- Misses       3401     3789     +388- Partials      899      921      +22
FlagCoverage Δ
unittest-go-65.87% <ø> (+0.13%)⬆️
unittest-go-macos-latest52.93% <ø> (+0.01%)⬆️
unittest-go-ubuntu-latest55.32% <ø> (+0.01%)⬆️
unittest-go-windows-202252.28% <ø> (+0.03%)⬆️
unittest-js59.09% <46.66%> (?)
Impacted FilesCoverage Δ
site/src/AppRouter.tsx0.00% <0.00%> (ø)
site/src/pages/preferences/index.tsx0.00% <0.00%> (ø)
site/src/components/Icons/DocsIcon.tsx100.00% <100.00%> (ø)
site/src/components/Navbar/UserDropdown.tsx96.29% <100.00%> (ø)
provisionersdk/transport.go78.72% <0.00%> (-6.39%)⬇️
peerbroker/proxy.go58.13% <0.00%> (-3.49%)⬇️
provisionerd/provisionerd.go80.17% <0.00%> (-1.03%)⬇️
coderd/provisionerdaemons.go62.05% <0.00%> (-1.02%)⬇️
site/src/components/Table/index.tsx0.00% <0.00%> (ø)
site/src/forms/CreateWorkspaceForm.tsx86.66% <0.00%> (ø)
... and91 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update23f9891...d17a808. Read thecomment docs.

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we storybook the user dropdown?

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresma
Copy link
CollaboratorAuthor

@vapurrmaid added storybook and unit tests

greyscaled reacted with heart emoji

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you merge latest main into this branch so that we get the Chromatic workflow to run

Copy link
Contributor

@presleyppresleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great test! Same comment on this one - can you pull out the labels into aLanguage constant and then, you can also use that constant in your tests to make them less brittle in what they target. Feel free not to in any cases where you think we should test that the language is actually what we expect it to be.

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresma
Copy link
CollaboratorAuthor

Good suggestion@presleyp, it is added!

Copy link
Contributor

@presleyppresleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Found a tiny thing but basically good to go!

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's safe to ignore the chromatic error here - it's because in#910 the secret token was deleted. You can either merge latest main, and CI will rerun, or just merge.

@BrunoQuaresmaBrunoQuaresma merged commit90388a3 intomainApr 7, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/usermenu branchApril 7, 2022 16:00
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@presleyppresleyppresleyp approved these changes

@greyscaledgreyscaledgreyscaled approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

User Menu - Beta
4 participants
@BrunoQuaresma@presleyp@greyscaled@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp