Adds BorderedMenu, BorderedMenuRow, Typography from v1
Adds AdminDropdown, based on v1 ManageDropdown
extracts OpenDropdown and CloseDropdown - arrows we can reuse in dropdowns
some reorganization of files and storybook
stories for BorderedMenu (which includes BorderedMenuRow), Typography, and AdminDropdown
test for AdminDropdown - currently just testing links, wrote a ticket to add and test that only admins see it but I don't think we have that capability yet. It's currently guarded by whether you are literallyadmin@coder.com 😂
add AuthAndNav to routes
~~remove Settings?~~ Tyler says to keep it

presleyp added6 commits

April 5, 2022 18:51

Start porting components for Admin menu

d6dacf9

Merge branch 'main' into admin/presleyp/591

f040a07

More porting, wip

a9e4dd4

Add icons

8944e10

Extract arrow components, navHeight

88bac07

Add Admin Dropdown

14b9e86

presleyp self-assigned this

Apr 6, 2022

Copy link

codecovbot commentedApr 6, 2022•
edited
Loading

Codecov Report

Merging#885 (1dfb981) intomain (4c1ef38) willincrease coverage by0.17%.
The diff coverage is82.07%.

@@            Coverage Diff             @@##             main     #885      +/-   ##==========================================+ Coverage   65.92%   66.10%   +0.17%==========================================  Files         228      238      +10       Lines       14126    14221      +95       Branches      105      115      +10     ==========================================+ Hits         9313     9401      +88  Misses       3868     3868- Partials      945      952       +7

Flag	Coverage Δ
unittest-go-macos-latest	`53.18% <ø> (-0.04%)`	⬇️
unittest-go-postgres-	`65.82% <ø> (-0.10%)`	⬇️
unittest-go-ubuntu-latest	`55.74% <ø> (+0.22%)`	⬆️
unittest-go-windows-2022	`52.53% <ø> (-0.06%)`	⬇️
unittest-js	`61.56% <82.07%> (+3.31%)`	⬆️

Impacted Files	Coverage Δ
site/src/AppRouter.tsx	`0.00% <0.00%> (ø)`
site/src/components/BorderedMenu/BorderedMenu.tsx	`100.00% <ø> (ø)`
site/src/components/TabPanel/TabSidebar.tsx	`0.00% <0.00%> (ø)`
site/src/pages/orgs/index.tsx	`0.00% <0.00%> (ø)`
site/src/pages/settings/index.tsx	`0.00% <0.00%> (ø)`
site/src/pages/users.tsx	`0.00% <0.00%> (ø)`
site/src/util/combineClasses.ts	`100.00% <ø> (ø)`
site/src/components/Navbar/NavbarView/index.tsx	`93.33% <80.00%> (ø)`
...src/components/BorderedMenuRow/BorderedMenuRow.tsx	`88.00% <88.00%> (ø)`
site/src/components/Typography/Typography.tsx	`90.90% <90.90%> (ø)`
... and17 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update4c1ef38...1dfb981. Read thecomment docs.

presleyp added2 commits

April 6, 2022 14:24

Format

b50b34d

Delete types

8b4834f

Copy link

Contributor

f0ssel commentedApr 6, 2022

So far on the backend we've removed a ton of settings in the "Admin UI" in favor of flags on the coder start command. At this time I can't think of any settings we'll need for MVP, so it seems fine to leave it off for now. I know Github Oauth will land on settings, but I think that's officially "not MVP". I think any work toward the page itself is fine, because we will probably need one eventually, but I wouldn't prioritize the work or link to it yet.

Copy link

Contributor

greyscaled commentedApr 6, 2022

Can you merge latest main into this branch so that we get the Chromatic workflow to run

presleyp added13 commits

April 7, 2022 15:18

Merge branch 'main' into admin/presleyp/591

25c5056

Fix styles

98ec516

Merge branch 'main' into admin/presleyp/591

4f7871e

Lint

1d4c94f

Add stub pages

f134141

Use navHeight constant

db542ca

Move files

a5ca439

Add and organize stories

6bb47e0

Storybook and organize text stories

bc84caf

Add test

675b195

Lint

a121c7e

Merge branch 'main' into admin/presleyp/591

babde57

Lint

466a43d

presleyp marked this pull request as ready for review

April 7, 2022 22:56

presleyp requested a review froma team as acode owner

April 7, 2022 22:56

code-asher reviewed

Apr 7, 2022

View reviewed changes

site/src/components/Navbar/AdminDropdown/index.tsx OutdatedShow resolvedHide resolved

presleyp added2 commits

April 8, 2022 00:42

Fix double navigation

f6342da

Lint

c78fa88

Wrap new routes in AuthAndNav

9a06d69

code-asher approved these changes

Apr 8, 2022

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love seeing all the tests and stories!

site/src/components/Navbar/Arrows.tsx Outdated

		@@ -0,0 +1,26 @@
		import { fade, makeStyles, Theme } from "@material-ui/core/styles"

Copy link

Member

code-asherApr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like how much more reusable these arrows are now.

site/src/components/Navbar/AdminDropdown/index.tsx Outdated

		path={entry.path}
		title={entry.label}
		variant="narrow"
		onClick={() => {

Copy link

Member

code-asherApr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is not something we need to address here but just a thought I had. I think all of the dropdown items as they exist in v1 could easily beNavLinks so I wonder if we should remove the ability to pass in anonClick and makepath required. Maybe that would promote making sure nav items really are regular anchor-based nav items, too (in v1 trying to open "add organization" in a new tab by middle-mouse clicking for example does nothing because it utilizesonClick for page navigation instead of being a standard<a>).