- Notifications
You must be signed in to change notification settings - Fork929
chore: Rename Projects to Templates#880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedApr 5, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #880 +/- ##==========================================+ Coverage 65.52% 65.75% +0.22%========================================== Files 216 216 Lines 13733 13733 Branches 103 103 ==========================================+ Hits 8999 9030 +31+ Misses 3807 3780 -27+ Partials 927 923 -4
Continue to review full report at Codecov.
|
I somehow net positive one line. Sucks to suck I guess. |
Customer feedback indicated projects was a confusing name.After querying the team internally, it seemed unanimousthat it is indeed a confusing name.Here's for a lil less confusion@ashmeer7 🥂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yolo
| @@ -23,7 +23,7 @@ const ( | |||
| // Compare checks the equality of passwords from a hashed pbkdf2 string. | |||
| // This uses pbkdf2 to ensure FIPS 140-2 compliance. See: | |||
| // https://csrc.nist.gov/csrc/media/projects/cryptographic-module-validation-program/documents/security-policies/140sp2261.pdf | |||
| // https://csrc.nist.gov/csrc/media/templates/cryptographic-module-validation-program/documents/security-policies/140sp2261.pdf | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
minor: 404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Impressive catch!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, just one broken URL in a comment (easy fix)
ashmeer7 commentedApr 6, 2022
This was the fastest I've ever complained about something to it being in code 👍 👍 |
Customer feedback indicated projects was a confusing name.After querying the team internally, it seemed unanimousthat it is indeed a confusing name.Here's for a lil less confusion@ashmeer7 🥂
Customer feedback indicated "projects" is a confusing name.
After querying the team internally, it seemed unanimous
that it is indeed a confusing name.
Here's to a lil less confusion@ashmeer7 🥂