Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: move oidc from experimental to ga#8742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 2 commits intomainfromstevenmasley/convert_oidc_ga
Jul 31, 2023

Conversation

@Emyrk
Copy link
Member

@EmyrkEmyrk commentedJul 26, 2023•
edited
Loading

Closes#8327

Feature is always on

PRs for feature:

Future Work

  • Handing email mismatch. Right now, if the emails do not match, we block the conversion attempt.
    • I think a solution to this is allowing admins to change emails on account. Right now we do not allow user's to change their email, so it should require an admin action.
  • You cannot go back to password auth.
    • This should only be able to be done by admins.

@EmyrkEmyrk marked this pull request as ready for reviewJuly 26, 2023 17:31
@EmyrkEmyrk changed the titlefeat: convert to oidc out of experimentalfeat: move oidc from experimental to gaJul 26, 2023
@EmyrkEmyrk requested a review frombpmctJuly 26, 2023 18:28
@Emyrk
Copy link
MemberAuthor

@bpmct can you green check this when you are ok to merge it from a releases perspective?

@EmyrkEmyrk requested a review fromjohnstcnJuly 26, 2023 18:29
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

Copy link
Member

@bpmctbpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I may have missed it, but can you add back

You can convert your account to use this login type by visiting your account settings.

That I removed in#8695

Emyrk reacted with thumbs up emoji
@EmyrkEmyrk merged commitcb36783 intomainJul 31, 2023
@EmyrkEmyrk deleted the stevenmasley/convert_oidc_ga branchJuly 31, 2023 15:30
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@bpmctbpmctbpmct approved these changes

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bring "Convert to OIDC" out of experimental

4 participants

@Emyrk@johnstcn@bpmct
[8]ページ先頭
©2009-2025 Movatter.jp