Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: use screen for reconnecting terminal sessions if available#8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 30 commits intomainfromasher/reconnection-with-screen
Aug 14, 2023
Merged
Changes from1 commit
Commits
Show all changes
30 commits
Select commitHold shift + click to select a range
0b8499d
Add screen backend for reconnecting ptys
code-asherJul 18, 2023
9cb043c
Fix leaking goroutine in wait
code-asherAug 8, 2023
19633c9
Remove connection_id from reconnecting PTY
code-asherAug 8, 2023
8f4956f
Remove error from close return
code-asherAug 8, 2023
ee887b9
Refactor reconnecting PTY backends
code-asherAug 8, 2023
1697070
Merge remote-tracking branch 'github/main' into asher/reconnection-wi…
code-asherAug 8, 2023
a2149fc
Remove extra mutex unlock
code-asherAug 8, 2023
e3c808b
Fix heartbeat typo in comment
code-asherAug 8, 2023
369a36e
Tweak connection close
code-asherAug 8, 2023
72d405c
Linter fixes
code-asherAug 8, 2023
e37fc0f
Clear active conns on close
code-asherAug 9, 2023
61a4253
Avoid useless buffer reset on close
code-asherAug 9, 2023
c7978db
Move lifecycle after buffer and process are set
code-asherAug 9, 2023
a083b31
Add info logs for starting, stopping, and attaching
code-asherAug 9, 2023
bb40f78
Do not hold mutex while waiting for state in screen
code-asherAug 9, 2023
089e1f9
Remove incorrect statement about closing on Attach
code-asherAug 9, 2023
ee67045
Remove backend type from SDK/API
code-asherAug 9, 2023
a6bcdd2
Use PATH to test buffered reconnecting pty
code-asherAug 9, 2023
3ff1510
Do not hold mutex while waiting for state
code-asherAug 9, 2023
a781173
Avoid clobbering attach error with close errors
code-asherAug 10, 2023
7a8ec2e
Immediately read screen process
code-asherAug 10, 2023
56ca7ac
Fix incorrect logger context on reconnecting PTY
code-asherAug 10, 2023
9b88a68
Protect map and state with the same mutex
code-asherAug 10, 2023
56e71c9
Fix incorrect test comment
code-asherAug 11, 2023
d4170ca
Attempt fixing flake with 'echo test' command
code-asherAug 11, 2023
34c5c1a
Avoid wait callback when context expires
code-asherAug 11, 2023
88a6b96
Remove err from wait callback
code-asherAug 11, 2023
1fd4e9a
Add state wait func where caller holds the lock
code-asherAug 14, 2023
57f464a
Merge remote-tracking branch 'github/main' into asher/reconnection-wi…
code-asherAug 14, 2023
968526d
Remove unused fn
code-asherAug 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Clear active conns on close
  • Loading branch information
@code-asher
code-asher committedAug 9, 2023
commite37fc0f18fcf439bb1e8c0863b326cd1b696530f
4 changes: 4 additions & 0 deletionsagent/reconnectingpty/buffered.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,6 +155,10 @@ func (rpty *bufferedReconnectingPTY) lifecycle(ctx context.Context, logger slog.
logger.Debug(ctx, "closed conn with error", slog.Error(err))
}
}
// Connections get removed once the pty closes but it is possible there is
// still some data that needs to be written so clear the map now to avoid
// writing to closed connections.
rpty.activeConns = map[string]net.Conn{}

err := rpty.ptty.Close()
if err != nil {
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp