- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: Add Section component#863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedApr 4, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #863 +/- ##==========================================- Coverage 65.81% 65.79% -0.02%========================================== Files 202 207 +5 Lines 13209 13333 +124 Branches 87 94 +7 ==========================================+ Hits 8693 8773 +80- Misses 3626 3663 +37- Partials 890 897 +7
Continue to review full report at Codecov.
|
| )} | ||
| {description && typeof description !== "string" && ( | ||
| <div className={styles.description}>{description}</div> | ||
| )} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well thought out!
| children: ( | ||
| <form style={{ display: "grid", gridAutoFlow: "row", gap: 12 }}> | ||
| <TextField label="Name" variant="filled" fullWidth /> | ||
| <TextField label="Email" variant="filled" fullWidth /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you give an example of usingSection.Action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I added it inside of thechildren props because it is just a wrapper component and maybe it is too much to add a separate storybook for it. What do you think?
presleyp left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great!
Closes#658