Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: fix release notes compare link#8581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 2 commits intomainfrombpmct/fix-releaselink
Jul 21, 2023
Merged

Conversation

bpmct
Copy link
Member

Didn't really want to break anything but let me know if there's a better way to do this.

matifali reacted with thumbs up emoji
@mafredri
Copy link
Member

@bpmct Nice catch! Looks like this is actually a bug inrelease.yaml. We should do e.g.version="v$(./scripts/version.sh)" instead ofversion="$(./scripts/version.sh)".

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pushed an alternate fix 👍🏻

@mafredrimafredri changed the titlechore: fix release notes compare linkci: fix release notes compare linkJul 21, 2023
@mafredrimafredri merged commit12b51ca intomainJul 21, 2023
@mafredrimafredri deleted the bpmct/fix-releaselink branchJuly 21, 2023 12:22
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 21, 2023
@mafredri
Copy link
Member

@bpmct went ahead and merged this so it'll be fixed in the next release 👍🏻

@bpmct
Copy link
MemberAuthor

Thanks!!

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@bpmctbpmct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bpmct@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp