NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

feat(helm): add commandArgs for custom entrypoint#8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

deansheather merged 5 commits intomainfromhelm-args

Jul 19, 2023

Merged

feat(helm): add commandArgs for custom entrypoint#8567

deansheather merged 5 commits intomainfromhelm-args

Jul 19, 2023

Conversation

Copy link

Member

ericpaulsen commentedJul 17, 2023•
edited
Loading

this PR adds thecommandArgs value to support passing custom arguments into the Coder container.

one of our large customers needs this feature to pass in a custom PostgreSQL connection URL environment variable. they are looking to reference the database password from a volume mounted on the container. the below example meets this requirement:

coder:command:    -/bin/sh    --c    -CODER_PG_CONNECTION_URL=postgresql://coder:$(cat /mnt/postgres-pass/secret.json | jq -r .password)@coder-db.coder.svc.cluster.local:5432/coder /opt/coder servercommandArgs:[]

feat(helm): add args conditional for custom entrypoint

9239c2d

ericpaulsen added the feature label

Jul 17, 2023

ericpaulsen requested review fromammario,deansheather andbpmct

July 17, 2023 19:07

ericpaulsen self-assigned this

Jul 17, 2023

Copy link

Member

deansheather commentedJul 17, 2023

I would prefer we just provided a.Values.coder.commandArgs value (default[]) instead, and if it's set we wouldn't set any args on the command.

e.g.:

coder:command:/bin/shcommandArgs:    -'-c'    -'echo "hello world" && coder server'

Default to[] instead of[ 'server' ] because we change it betweenserver andwsproxy server in the templates.

deansheather reviewed

Jul 17, 2023

View reviewed changes

Copy link

Member

deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Commented above

refactor: commandArgs

1d9598b

ericpaulsen requested a review fromdeansheather

July 17, 2023 21:30

Copy link

MemberAuthor

ericpaulsen commentedJul 17, 2023

thanks@deansheather - how should we specifyserver in thecoder.yaml template?

deansheather reviewed

Jul 17, 2023

View reviewed changes

helm/templates/coder.yaml OutdatedShow resolvedHide resolved

helm/values.yaml OutdatedShow resolvedHide resolved

ammario removed their request for review

July 17, 2023 21:52

add: nested conditional for wsproxy

e4dddde

deansheather reviewed

Jul 18, 2023

View reviewed changes

Copy link

Member

deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Needs a test in the tests dir, you can add a test by adding it to the list in the_test.go file and adding a corresponding values file with the same name in the testdata dir. Then runmake --always-make update-golden-files to save the generated chart for your test. Double check the outputted file before committing to make sure it looks as you would expect