Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add offline docs#8527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 13 commits intomainfrombq/offline-docs
Jul 19, 2023
Merged

feat: add offline docs#8527

BrunoQuaresma merged 13 commits intomainfrombq/offline-docs
Jul 19, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedJul 14, 2023•
edited
Loading

Related to#5466

Screen Shot 2023-07-14 at 15 30 36

matifali reacted with thumbs up emoji
@BrunoQuaresmaBrunoQuaresma self-assigned thisJul 14, 2023
@bpmct
Copy link
Member

So this is going to be in a different artifact?#8110

@BrunoQuaresma
Copy link
CollaboratorAuthor

@bpmct Yes, so the user can download the .tar file and host the docs where they want to.

@matifali
Copy link
Member

@BrunoQuaresma but we should make it linkable from the Coder dashboard.

@BrunoQuaresma
Copy link
CollaboratorAuthor

You can follow the RFC discussion to see the reasons we decided to not do it rn but it can be added in the future if we see more users asking for the feature.

matifali reacted with thumbs up emoji

@bpmct
Copy link
Member

Ah, but I thought we are going to support setting a custom docs link URL for in-product docs links?

CODER_DOCS_URL=https://coder-docs.example.com/

Screenshot 2023-07-15 at 2 56 10 PM

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also, you may wish to keep the dependencies updated by adding an entry for offlinedocs in.github/dependabot.yaml

@matifali
Copy link
Member

I like the light theme.

BrunoQuaresma reacted with heart emoji

@BrunoQuaresma
Copy link
CollaboratorAuthor

Ah, but I thought we are going to support setting a custom docs link URL for in-product docs links?

CODER_DOCS_URL=https://coder-docs.example.com/

Screenshot 2023-07-15 at 2 56 10 PM

We definitely can do it. It is very easy, thanks for bringing this.

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would suggest adding an entry for offline docs todependabot.yaml.
Other than that ci looks good.

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresma
Copy link
CollaboratorAuthor

I think for now it is ok to not have a dependabot for the offlinedocs but I will keep that in mind for sure.

matifali reacted with thumbs up emoji

@deansheather
Copy link
Member

I changed it to.tgz (aka..tar.gz) to match our Helm artifact. It'll show up in the release ascoder_docs_$(VERSION).tgz

BrunoQuaresma reacted with thumbs up emoji

@BrunoQuaresma
Copy link
CollaboratorAuthor

/deploy-pr

@BrunoQuaresmaBrunoQuaresma merged commitacc12d3 intomainJul 19, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/offline-docs branchJuly 19, 2023 16:57
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 19, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@matifalimatifalimatifali approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BrunoQuaresma@bpmct@matifali@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp