Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): add build parameters option when starting or restarting a workspace#8524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 15 commits intomainfrombq/ephemeral-parameter
Jul 18, 2023
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
Show all changes
15 commits
Select commitHold shift + click to select a range
5334762
Add base for ephemeral form
BrunoQuaresmaJul 13, 2023
6872b63
Make fields look better
BrunoQuaresmaJul 14, 2023
c4984b8
Add empty state
BrunoQuaresmaJul 14, 2023
606b5ea
Merge branch 'main' into bq/ephemeral-parameter
matifaliJul 17, 2023
fddfead
Merge branch 'main' into bq/ephemeral-parameter
BrunoQuaresmaJul 17, 2023
36e5c8c
Fix initial values
BrunoQuaresmaJul 17, 2023
1269df1
Remove context value
BrunoQuaresmaJul 17, 2023
f5a820b
Add ephemeral parameters section
BrunoQuaresmaJul 17, 2023
09f40e3
Merge branch 'bq/ephemeral-parameter' of https://github.com/coder/cod…
BrunoQuaresmaJul 17, 2023
e172354
Merge branch 'main' into bq/ephemeral-parameter
mtojekJul 18, 2023
98fd6f8
Don't show ephemeral parameters on create form
BrunoQuaresmaJul 18, 2023
e4f1a3c
Merge branch 'bq/ephemeral-parameter' of https://github.com/coder/cod…
BrunoQuaresmaJul 18, 2023
469dca2
Minor improvements
BrunoQuaresmaJul 18, 2023
e4d9243
Fix circular json error
BrunoQuaresmaJul 18, 2023
5d35955
Always use default values for ephemeral parameters
BrunoQuaresmaJul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletionsite/src/api/api.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -519,11 +519,13 @@ export const startWorkspace = (
workspaceId: string,
templateVersionId: string,
logLevel?: TypesGen.CreateWorkspaceBuildRequest["log_level"],
buildParameters?: TypesGen.WorkspaceBuildParameter[],
) =>
postWorkspaceBuild(workspaceId, {
transition: "start",
template_version_id: templateVersionId,
log_level: logLevel,
rich_parameter_values: buildParameters,
})
export const stopWorkspace = (
workspaceId: string,
Expand DownExpand Up@@ -552,7 +554,13 @@ export const cancelWorkspaceBuild = async (
return response.data
}

export const restartWorkspace = async (workspace: TypesGen.Workspace) => {
export const restartWorkspace = async ({
workspace,
buildParameters,
}: {
workspace: TypesGen.Workspace
buildParameters?: TypesGen.WorkspaceBuildParameter[]
}) => {
const stopBuild = await stopWorkspace(workspace.id)
const awaitedStopBuild = await waitForBuild(stopBuild)

Expand All@@ -564,6 +572,8 @@ export const restartWorkspace = async (workspace: TypesGen.Workspace) => {
const startBuild = await startWorkspace(
workspace.id,
workspace.latest_build.template_version_id,
undefined,
buildParameters,
)
await waitForBuild(startBuild)
}
Expand DownExpand Up@@ -1346,3 +1356,15 @@ export const issueReconnectingPTYSignedToken = async (
)
return response.data
}

export const getWorkspaceParameters = async (workspace: TypesGen.Workspace) => {
const latestBuild = workspace.latest_build
const [templateVersionRichParameters, buildParameters] = await Promise.all([
getTemplateVersionRichParameters(latestBuild.template_version_id),
getWorkspaceBuildParameters(latestBuild.id),
])
return {
templateVersionRichParameters,
buildParameters,
}
}
20 changes: 12 additions & 8 deletionssite/src/components/LoadingButton/LoadingButton.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,25 @@
import {FC } from "react"
import {forwardRef } from "react"
import MuiLoadingButton, {
LoadingButtonProps as MuiLoadingButtonProps,
} from "@mui/lab/LoadingButton"

export type LoadingButtonProps = MuiLoadingButtonProps

export const LoadingButton: FC<LoadingButtonProps> = ({
children,
loadingIndicator,
...buttonProps
}) => {
export const LoadingButton = forwardRef<
HTMLButtonElement,
MuiLoadingButtonProps
>(({ children, loadingIndicator, ...buttonProps }, ref) => {
return (
<MuiLoadingButton variant="outlined" color="neutral" {...buttonProps}>
<MuiLoadingButton
variant="outlined"
color="neutral"
ref={ref}
{...buttonProps}
>
{/* known issue: https://github.com/mui/material-ui/issues/27853 */}
<span>
{buttonProps.loading && loadingIndicator ? loadingIndicator : children}
</span>
</MuiLoadingButton>
)
}
})
8 changes: 6 additions & 2 deletionssite/src/components/Markdown/Markdown.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,17 +12,21 @@ import { Prism as SyntaxHighlighter } from "react-syntax-highlighter"
import gfm from "remark-gfm"
import { colors } from "theme/colors"
import { darcula } from "react-syntax-highlighter/dist/cjs/styles/prism"
import { combineClasses } from "utils/combineClasses"

export interface MarkdownProps {
children: string
}

export const Markdown: FC<{ children: string }> = ({ children }) => {
export const Markdown: FC<{ children: string; className?: string }> = ({
children,
className,
}) => {
const styles = useStyles()

return (
<ReactMarkdown
className={styles.markdown}
className={combineClasses([styles.markdown, className])}
remarkPlugins={[gfm]}
components={{
a: ({ href, target, children }) => (
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp