- Notifications
You must be signed in to change notification settings - Fork928
test(agent): fix service banner and metadata intervals#8516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I feel like these tests would be less racy if we could pass achan time.Time
between the agent being tested and the unit test itself.
I think the entire metadata test could use a re-think, we already know when the agent posts updates due to injected function so we could utilize that knowledge. AFAICT there’s no race in the service banner test though and the intent in this PR was to remove the conditional test code to avoid such use in the future. |
No description provided.