Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: use names for all GitHub actions steps and use sqlc setup action#8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 7 commits intomainfrommatifali-
Jul 13, 2023

Conversation

matifali
Copy link
Member

@matifalimatifali commentedJul 13, 2023
edited
Loading

  1. Use the officially available sqlc-setup action in ci
    https://docs.sqlc.dev/en/v1.19.0/howto/ci-cd.html#github-workflows
  2. Name all steps in jobs

@matifalimatifali self-assigned thisJul 13, 2023
cdr-bot[bot]
cdr-botbot previously approved these changesJul 13, 2023
Copy link

@cdr-botcdr-botbot left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ❌ Less than 100 lines

@matifalimatifalienabled auto-merge (squash)July 13, 2023 13:03
@matifalimatifalidisabled auto-mergeJuly 13, 2023 13:13
@cdr-botcdr-botbot dismissed theirstale reviewJuly 13, 2023 13:18

This PR is no longer a hotfix.

@matifalimatifali added hotfix and removed hotfix labelsJul 13, 2023
@matifalimatifali changed the titlechore: use sqlc setup actionrefactor: refactor ciJul 13, 2023
Copy link
Member

@ammarioammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@kylecarbs -- what's the status of your Nix work on CI?

@matifali
Copy link
MemberAuthor

@ammario this is mostly a cosmetic change and doesn't change any behavior.

Copy link
Member

@ammarioammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@matifali I see. The current PR title suggests a far more expansive refactor, so I think it should be changed before merge.

matifali reacted with thumbs up emoji
@matifalimatifali changed the titlerefactor: refactor cichore: name all steps in ciJul 13, 2023
@matifalimatifali changed the titlechore: name all steps in cichore: use names for all GitHub actions steps and use sqlc setup actionJul 13, 2023
@matifalimatifali merged commitbe10138 intomainJul 13, 2023
@matifalimatifali deleted the matifali- branchJuly 13, 2023 19:46
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ammarioammarioammario approved these changes

@cdr-botcdr-bot[bot]cdr-bot[bot] left review comments

@coadlercoadlerAwaiting requested review from coadler

Assignees

@matifalimatifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@matifali@ammario

[8]ページ先頭

©2009-2025 Movatter.jp