Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): display version message#8435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 14 commits intomainfrombq/add-version-message
Jul 13, 2023
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedJul 11, 2023•
edited by matifali
Loading

Display version message on:

  • Outdated tooltip
  • Template version header page
  • Add a message field when creating a new version in the UI
Screen Shot 2023-07-11 at 16 24 25Screen Shot 2023-07-11 at 16 29 03

Close#8342
closes:#3775

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nicely done! Thought about handling one more case with existing and empty message (see comments).

@matifali
Copy link
Member

Also, consider
#8456

@BrunoQuaresma
Copy link
CollaboratorAuthor

Close#3775

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I fixed an issue in the last commits if you want to take a look, but other than that, this looks good!

One last question, were we planning on showing message as column in this table too?

image

@BrunoQuaresma
Copy link
CollaboratorAuthor

@mafredri I think for this design, it would be too much but I will think more about that after this PR 🤔 we probably can make a better use of a different design for this.

mafredri reacted with thumbs up emojimafredri reacted with heart emoji

@BrunoQuaresmaBrunoQuaresma merged commitb833861 intomainJul 13, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/add-version-message branchJuly 13, 2023 13:36
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add into the UI the version message Add a changelog/message on template push
3 participants
@BrunoQuaresma@matifali@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp