Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): add warning for unhealthy workspace#8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 3 commits intomainfrombq/unhealthy-warning
Jul 12, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Added a warning in the workspace page:
Screen Shot 2023-07-11 at 10 07 25

Added a warning icon as we do when showing the outdated warning:
Screen Shot 2023-07-11 at 10 04 02

Close#8343

@BrunoQuaresmaBrunoQuaresma self-assigned thisJul 11, 2023
@BrunoQuaresmaBrunoQuaresma changed the titlefeat(site): make noticeable when a workspace is unhealthyfeat(site): add warning for unhealthy workspaceJul 11, 2023
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested a small rephrasing, but otherwise looks good. Should we expand the mock data in the stories to more closely resemble the response for unhealthy? (E.g. an uuid in failing agents and modify the resource to set the agent health too.)

@BrunoQuaresmaBrunoQuaresma merged commitbff73ad intomainJul 12, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/unhealthy-warning branchJuly 12, 2023 13:27
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Improve UI for when one of the agents are unhealthy

2 participants

@BrunoQuaresma@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp