Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add buildinfo package to embed version#840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromversion
Apr 5, 2022
Merged

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedApr 3, 2022•
edited
Loading

This also resolves build time and commit hash using the
Go 1.18 debug/buildinfo package. An external URL is outputted
on running version as well to easily route the caller to a
release or commit.

Closes#493.

# devm~/P/c/coder (version*s) go run ./cmd/coder -vCoder v0.0.0-devel+1003b0f Sun Apr  3 20:37:27 UTC 2022https://github.com/coder/coder/commit/1003b0fe5a3d41fb4626c7efb6b45c1edefcb67d# prodm~/P/c/coder (version s) ./dist/coder-slim_linux_amd64/coder -vCoder v0.3.4+1003b0f Sun Apr  3 20:37:27 UTC 2022https://github.com/coder/coder/commit/1003b0fe5a3d41fb4626c7efb6b45c1edefcb67d

@kylecarbskylecarbs requested a review fromcoadlerApril 3, 2022 20:37
@kylecarbskylecarbs self-assigned thisApr 3, 2022
@codecov
Copy link

codecovbot commentedApr 3, 2022•
edited
Loading

Codecov Report

Merging#840 (5e22769) intomain (ccba2ba) willdecrease coverage by0.26%.
The diff coverage is59.61%.

@@            Coverage Diff             @@##             main     #840      +/-   ##==========================================- Coverage   66.06%   65.80%   -0.27%==========================================  Files         202      205       +3       Lines       13209    13309     +100       Branches       87       87              ==========================================+ Hits         8727     8758      +31- Misses       3600     3655      +55- Partials      882      896      +14
FlagCoverage Δ
unittest-go-65.20% <59.61%> (-0.26%)⬇️
unittest-go-macos-latest52.57% <59.61%> (+0.10%)⬆️
unittest-go-ubuntu-latest55.20% <59.61%> (+0.26%)⬆️
unittest-go-windows-202251.91% <59.61%> (+0.21%)⬆️
unittest-js62.36% <ø> (-0.28%)⬇️
Impacted FilesCoverage Δ
cli/buildinfo/buildinfo.go56.09% <56.09%> (ø)
cli/root.go76.41% <72.72%> (-0.43%)⬇️
codersdk/provisionerdaemons.go58.46% <0.00%> (-6.16%)⬇️
coderd/provisionerdaemons.go58.51% <0.00%> (-4.56%)⬇️
provisioner/echo/serve.go56.80% <0.00%> (-2.41%)⬇️
coderd/parameter/compute.go74.07% <0.00%> (-2.23%)⬇️
provisionerd/provisionerd.go80.32% <0.00%> (-1.18%)⬇️
coderd/database/queries.sql.go83.30% <0.00%> (-0.23%)⬇️
site/src/Main.tsx0.00% <0.00%> (ø)
coderd/autostart/schedule/schedule.go83.33% <0.00%> (ø)
... and6 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateccba2ba...5e22769. Read thecomment docs.

if !valid {
return repo
}
return repo + "/commit/" + revision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

path.Join might make this a bit cleaner!

kylecarbs reacted with thumbs up emoji
This also resolves build time and commit hash using theGo 1.18 debug/buildinfo package. An external URL is outputtedon running version as well to easily route the caller to arelease or commit.
@kylecarbskylecarbsenabled auto-merge (squash)April 5, 2022 01:31
@kylecarbskylecarbs merged commit5ae71f0 intomainApr 5, 2022
@kylecarbskylecarbs deleted the version branchApril 5, 2022 01:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coadlercoadlercoadler approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embed version in CLI
2 participants
@kylecarbs@coadler
[8]ページ先頭
©2009-2025 Movatter.jp