Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Remove line length limit on MacOS for input prompts#839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfrommacterm
Apr 3, 2022

Conversation

kylecarbs
Copy link
Member

This caused inputs to be truncated on MacOS terminals.

@codecov
Copy link

codecovbot commentedApr 3, 2022•
edited
Loading

Codecov Report

Merging#839 (d7fbb1a) intomain (2a7ab08) willdecrease coverage by0.26%.
The diff coverage is3.33%.

@@            Coverage Diff             @@##             main     #839      +/-   ##==========================================- Coverage   65.86%   65.60%   -0.27%==========================================  Files         200      202       +2       Lines       13179    13209      +30       Branches       87       87              ==========================================- Hits         8681     8666      -15- Misses       3607     3649      +42- Partials      891      894       +3
FlagCoverage Δ
unittest-go-65.07% <9.09%> (-0.23%)⬇️
unittest-go-macos-latest52.37% <3.57%> (-0.09%)⬇️
unittest-go-ubuntu-latest54.94% <9.09%> (-0.18%)⬇️
unittest-go-windows-202251.73% <9.09%> (+0.01%)⬆️
unittest-js62.63% <ø> (ø)
Impacted FilesCoverage Δ
cli/cliui/cliui_darwin.go0.00% <0.00%> (ø)
cli/cliui/cliui_other.go0.00% <0.00%> (ø)
cli/cliui/prompt.go71.60% <11.11%> (-7.57%)⬇️
peer/conn.go77.66% <0.00%> (-2.80%)⬇️
provisioner/echo/serve.go54.40% <0.00%> (-2.40%)⬇️
provisionerd/provisionerd.go77.97% <0.00%> (-1.18%)⬇️
coderd/provisionerdaemons.go60.03% <0.00%> (-0.51%)⬇️
peer/channel.go83.62% <0.00%> (+0.58%)⬆️
coderd/workspaceresources.go59.34% <0.00%> (+3.25%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update2a7ab08...d7fbb1a. Read thecomment docs.

@kylecarbskylecarbsforce-pushed themacterm branch 2 times, most recently frome498821 to4e87001CompareApril 3, 2022 17:40
This caused inputs to be truncated on MacOS terminals.
@kylecarbskylecarbsenabled auto-merge (squash)April 3, 2022 18:08
@kylecarbskylecarbs merged commitccba2ba intomainApr 3, 2022
@kylecarbskylecarbs deleted the macterm branchApril 3, 2022 18:09
spikecurtis added a commit that referenced this pull requestMay 10, 2022
Revert "fix: Remove line length limit on MacOS for input prompts (#839)"This reverts commitccba2ba.
spikecurtis added a commit that referenced this pull requestMay 10, 2022
Revert "fix: Remove line length limit on MacOS for input prompts (#839)"This reverts commitccba2ba.
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Revert "fix: Remove line length limit on MacOS for input prompts (#839)"This reverts commitccba2ba.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coadlercoadlercoadler approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kylecarbs@coadler
[8]ページ先頭
©2009-2025 Movatter.jp