NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

fix: use`golang.org/x/term` instead of`golang.org/x/crypto/ssh/terminal`#837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 1 commit intomainfromcolin/x-term

Apr 1, 2022

Merged

fix: use`golang.org/x/term` instead of`golang.org/x/crypto/ssh/terminal`#837

coadler merged 1 commit intomainfromcolin/x-term

Apr 1, 2022

Conversation

Copy link

Contributor

coadler commentedApr 1, 2022

The latter is deprecated:https://pkg.go.dev/golang.org/x/crypto/ssh/terminal

The deprecated packages linter doesn't seem to be working in 1.18 😞

fix: usegolang.org/x/term instead of `golang.org/x/crypto/ssh/term…

332304a

…inal`The latter is deprecated:https://pkg.go.dev/golang.org/x/crypto/ssh/terminal

coadler requested a review fromkylecarbs

April 1, 2022 21:17

coadler self-assigned this

Apr 1, 2022

Copy link

codecovbot commentedApr 1, 2022•
edited
Loading

Codecov Report

Merging#837 (332304a) intomain (fd52310) willdecrease coverage by0.36%.
The diff coverage is0.00%.

@@            Coverage Diff             @@##             main     #837      +/-   ##==========================================- Coverage   66.13%   65.76%   -0.37%==========================================  Files         200      196       -4       Lines       13179    12993     -186       Branches       87       87              ==========================================- Hits         8716     8545     -171+ Misses       3582     3573       -9+ Partials      881      875       -6

Flag	Coverage Δ
unittest-go-	`65.39% <0.00%> (-0.20%)`	⬇️
unittest-go-macos-latest	`?`
unittest-go-ubuntu-latest	`55.01% <0.00%> (-0.22%)`	⬇️
unittest-go-windows-2022	`?`
unittest-js	`62.63% <ø> (ø)`

Impacted Files	Coverage Δ
cli/ssh.go	`39.84% <0.00%> (ø)`
cli/configssh.go	`50.00% <0.00%> (-8.04%)`	⬇️
provisionersdk/transport.go	`78.72% <0.00%> (-6.39%)`	⬇️
codersdk/provisionerdaemons.go	`58.46% <0.00%> (-6.16%)`	⬇️
pty/ptytest/ptytest.go	`89.65% <0.00%> (-5.18%)`	⬇️
cli/projectinit.go	`56.36% <0.00%> (-3.64%)`	⬇️
provisioner/echo/serve.go	`54.40% <0.00%> (-2.40%)`	⬇️
peer/conn.go	`78.93% <0.00%> (-2.29%)`	⬇️
provisionerd/provisionerd.go	`79.58% <0.00%> (-2.06%)`	⬇️
peer/channel.go	`83.04% <0.00%> (-0.59%)`	⬇️
... and6 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatefd52310...332304a. Read thecomment docs.