Jul 10, 2023 · Jul 7, 2023 · Jul 7, 2023 · Jul 7, 2023 · Jul 7, 2023 · Jul 7, 2023
diff --git a/codersdk/richparameters_test.go b/codersdk/richparameters_test.go
 }
 })
 }

 func TestParameterResolver_ValidateResolve_Ephemeral_OverridePrevious(t *testing.T) {
 t.Parallel()
 uut := codersdk.ParameterResolver{
 Rich: []codersdk.WorkspaceBuildParameter{{Name: "n", Value: "5"}},
 }
 p := codersdk.TemplateVersionParameter{
 Name:      "n",
 Type:      "number",
 Mutable:   true,
 Required:  true,
 Ephemeral: true,
 }
 v, err := uut.ValidateResolve(p, &codersdk.WorkspaceBuildParameter{
 Name:  "n",
 Value: "6",
 })
 require.NoError(t, err)
 require.Equal(t, "6", v)
 }

 func TestParameterResolver_ValidateResolve_Ephemeral_FirstTime(t *testing.T) {
 t.Parallel()
 uut := codersdk.ParameterResolver{}
 p := codersdk.TemplateVersionParameter{
 Name:      "n",
 Type:      "number",
 Mutable:   true,
 Required:  true,
 Ephemeral: true,
 }
 v, err := uut.ValidateResolve(p, &codersdk.WorkspaceBuildParameter{
 Name:  "n",
 Value: "6",
 })
 require.NoError(t, err)
 require.Equal(t, "6", v)
 }

 func TestParameterResolver_ValidateResolve_Ephemeral_UseDefault(t *testing.T) {
 t.Parallel()
 uut := codersdk.ParameterResolver{}
 p := codersdk.TemplateVersionParameter{
 Name:         "n",
 Type:         "number",
 Mutable:      true,
 DefaultValue: "5",
 Ephemeral:    true,
 }
 v, err := uut.ValidateResolve(p, nil)
 require.NoError(t, err)
 require.Equal(t, "5", v)
 }

 func TestParameterResolver_ValidateResolve_Ephemeral_UseEmptyDefault(t *testing.T) {
 t.Parallel()
 uut := codersdk.ParameterResolver{}
 p := codersdk.TemplateVersionParameter{
 Name:         "n",
 Type:         "number",
 Mutable:      true,
 DefaultValue: "",
 Ephemeral:    true,
 }
 v, err := uut.ValidateResolve(p, nil)
 require.NoError(t, err)
 require.Equal(t, "", v)
 }

 func TestParameterResolver_ValidateResolve_Ephemeral_RequiredButMissing(t *testing.T) {
 t.Parallel()
 uut := codersdk.ParameterResolver{}
 p := codersdk.TemplateVersionParameter{
 Name:      "n",
 Type:      "number",
 Mutable:   true,
 Required:  true,
 Ephemeral: true,
 }
 // It is more theoretical than practical case. Schema allows to configure a parameter,
 // which always requires from initiator to provide the value, but it is not persisted between
 // consecutive workspace builds.
 v, err := uut.ValidateResolve(p, nil)
 require.Error(t, err) // Parameter is required, but not provided.
 require.Equal(t, "", v)
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -304,3 +304,89 @@ func TestRichParameterValidation(t *testing.T) {
		}
		})
		}

		func TestParameterResolver_ValidateResolve_Ephemeral_OverridePrevious(t *testing.T) {
		t.Parallel()
		uut := codersdk.ParameterResolver{
		Rich: []codersdk.WorkspaceBuildParameter{{Name: "n", Value: "5"}},
		}
		p := codersdk.TemplateVersionParameter{
		Name: "n",
		Type: "number",
		Mutable: true,
		Required: true,
		Ephemeral: true,
		}
		v, err := uut.ValidateResolve(p, &codersdk.WorkspaceBuildParameter{
		Name: "n",
		Value: "6",
		})
		require.NoError(t, err)
		require.Equal(t, "6", v)
		}

		func TestParameterResolver_ValidateResolve_Ephemeral_FirstTime(t *testing.T) {
		t.Parallel()
		uut := codersdk.ParameterResolver{}
		p := codersdk.TemplateVersionParameter{
		Name: "n",
		Type: "number",
		Mutable: true,
		Required: true,
		Ephemeral: true,
Comment on lines +335 to +336 Copy link Member johnstcnJul 10, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This is an interesting use-case - a required ephemeral value could be the equivalent of a TOS checkbox when building a workspace e.g. "I solemnly swear to not use this workspace for evil. [x]" mtojek reacted with laugh emoji
		}
		v, err := uut.ValidateResolve(p, &codersdk.WorkspaceBuildParameter{
		Name: "n",
		Value: "6",
		})
		require.NoError(t, err)
		require.Equal(t, "6", v)
		}

		func TestParameterResolver_ValidateResolve_Ephemeral_UseDefault(t *testing.T) {
		t.Parallel()
		uut := codersdk.ParameterResolver{}
		p := codersdk.TemplateVersionParameter{
		Name: "n",
		Type: "number",
		Mutable: true,
		DefaultValue: "5",
		Ephemeral: true,
		}
		v, err := uut.ValidateResolve(p, nil)
		require.NoError(t, err)
		require.Equal(t, "5", v)
		}

		func TestParameterResolver_ValidateResolve_Ephemeral_UseEmptyDefault(t *testing.T) {
		t.Parallel()
		uut := codersdk.ParameterResolver{}
		p := codersdk.TemplateVersionParameter{
		Name: "n",
		Type: "number",
		Mutable: true,
		DefaultValue: "",
		Ephemeral: true,
		}
		v, err := uut.ValidateResolve(p, nil)
		require.NoError(t, err)
		require.Equal(t, "", v)
		}

		func TestParameterResolver_ValidateResolve_Ephemeral_RequiredButMissing(t *testing.T) {
Copy link Member mafredriJul 10, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. What about a case where required = true, but there's also a default value set? Is this possible and should we test it? Copy link MemberAuthor mtojekJul 10, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It is not possible as`required` is a computed property, the opposite ofoptional, convertedhere. mafredri reacted with thumbs up emoji
		t.Parallel()
		uut := codersdk.ParameterResolver{}
		p := codersdk.TemplateVersionParameter{
		Name: "n",
		Type: "number",
		Mutable: true,
		Required: true,
		Ephemeral: true,
		}
		// It is more theoretical than practical case. Schema allows to configure a parameter,
		// which always requires from initiator to provide the value, but it is not persisted between
		// consecutive workspace builds.
		v, err := uut.ValidateResolve(p, nil)
		require.Error(t, err) // Parameter is required, but not provided.
		require.Equal(t, "", v)
		}