- Notifications
You must be signed in to change notification settings - Fork1k
feat: enable Terraform template-wide variables by default#8334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be marked as a breaking change:
feat!: enable Terraform template-wide variables by defaultApart from that, what will happen if someone attempts to use an existing template with the below stanza?
provider "coder" { feature_use_managed_variables = "true"}Will they be directed to removefeature_use_managed_variables?
Nothing happens, the feature flag is just ignored, hence I was not convinced to mark it as a breaking change. Someday in the future, we will update the coder provider schema to block the flag. Then, the coder will complain about an unknown feature flag. |
Got it - that's fine. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't the Coder provider be bumped to 0.10.0? In all of the example templates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is a valid point, but I'd rather do this in a separate PR as more examples will be affected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good 👍🏻
| ##Managed Terraform variables | ||
| ##Terraform template-wide variables | ||
| >⚠️ Flag`feature_use_managed_variables` is available until v0.25.0 (Jul 2023) release. After this release, template-wide Terraform variables will be enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should this mention the coder provider version as well? (Edit: On second thought, maybe not.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In theory, terraform-provider-coder still accepts thefeature_use_managed_variables, so maybe not overcomplicate it :)
Uh oh!
There was an error while loading.Please reload this page.
Related:coder/terraform-provider-coder#140
Changes:
feature_use_managed_variablesfeature_use_managed_variablesis considered to be the only mode. The flag isignored in the schema, and will be removed eventually.