Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Add provisionerd protobuf definitions#83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 5 commits intomainfromprovisionerdproto
Jan 29, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedJan 29, 2022
edited
Loading

Provisionerd communicates with coderd over a multiplexed
WebSocket serving dRPC. This adds a roughly accurate protocol
definition.

It shares definitions with "provisioner.proto" for simple
interop with provisions!

This modifies a prior migration which is typically forbidden,but because we're pre-production deployment I felt groupingwould be helpful to future contributors.This adds database functions that are required for the provisionerdaemon and job queue logic.
Adds a projectparameter package to compute build-time projectvalues for a provided scope.This package will be used to return which variables are beingused for a build, and can visually indicate the hierarchy toa user.
Provisionerd communicates with coderd over a multiplexedWebSocket serving dRPC. This adds a roughly accurate protocoldefinition.It shares definitions with "provisioner.proto" for simpleinterop with provisioners!
@kylecarbskylecarbs self-assigned thisJan 29, 2022
@codecov
Copy link

codecovbot commentedJan 29, 2022
edited
Loading

Codecov Report

Merging#83 (2dc34f6) intomain (b3c5bb3) willdecrease coverage by0.25%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##             main      #83      +/-   ##==========================================- Coverage   71.70%   71.45%   -0.26%==========================================  Files          89       89                Lines        3563     3563                Branches       55       55              ==========================================- Hits         2555     2546       -9- Misses        787      794       +7- Partials      221      223       +2
FlagCoverage Δ
unittest-go-macos-latest67.15% <ø> (ø)
unittest-go-ubuntu-latest69.56% <ø> (-0.04%)⬇️
unittest-go-windows-latest67.04% <ø> (-0.07%)⬇️
unittest-js78.30% <ø> (ø)
Impacted FilesCoverage Δ
peer/conn.go73.47% <0.00%> (-2.75%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb3c5bb3...2dc34f6. Read thecomment docs.

@kylecarbskylecarbs changed the base branch frommain toprojectparameterJanuary 29, 2022 16:04
@@ -1,3 +1,4 @@
# Generated files
peerbroker/proto/*.golinguist-generated=true
provisionerd/proto/*.golinguist-generated=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for adding this 👍

kylecarbs reacted with heart emoji
Comment on lines +6 to +9
bin/provisionerd:
mkdir -p bin
go build -o bin/provisionerd cmd/provisionerd/main.go
.PHONY: bin/provisionerd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! This is a big chunk to get in towards black triangle 🎉

kylecarbs reacted with rocket emoji
Base automatically changed fromprojectparameter tomainJanuary 29, 2022 23:45
@kylecarbskylecarbs merged commit2b922b1 intomainJan 29, 2022
@kylecarbskylecarbs deleted the provisionerdproto branchJanuary 29, 2022 23:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@bryphe-coderbryphe-coderbryphe-coder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kylecarbskylecarbs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kylecarbs@bryphe-coder

[8]ページ先頭

©2009-2025 Movatter.jp