- Notifications
You must be signed in to change notification settings - Fork1k
feat: Add provisionerd protobuf definitions#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This modifies a prior migration which is typically forbidden,but because we're pre-production deployment I felt groupingwould be helpful to future contributors.This adds database functions that are required for the provisionerdaemon and job queue logic.
Adds a projectparameter package to compute build-time projectvalues for a provided scope.This package will be used to return which variables are beingused for a build, and can visually indicate the hierarchy toa user.
Provisionerd communicates with coderd over a multiplexedWebSocket serving dRPC. This adds a roughly accurate protocoldefinition.It shares definitions with "provisioner.proto" for simpleinterop with provisioners!
codecovbot commentedJan 29, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #83 +/- ##==========================================- Coverage 71.70% 71.45% -0.26%========================================== Files 89 89 Lines 3563 3563 Branches 55 55 ==========================================- Hits 2555 2546 -9- Misses 787 794 +7- Partials 221 223 +2
Continue to review full report at Codecov.
|
@@ -1,3 +1,4 @@ | |||
# Generated files | |||
peerbroker/proto/*.golinguist-generated=true | |||
provisionerd/proto/*.golinguist-generated=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for adding this 👍
bin/provisionerd: | ||
mkdir -p bin | ||
go build -o bin/provisionerd cmd/provisionerd/main.go | ||
.PHONY: bin/provisionerd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice! This is a big chunk to get in towards black triangle 🎉
Uh oh!
There was an error while loading.Please reload this page.
Provisionerd communicates with coderd over a multiplexed
WebSocket serving dRPC. This adds a roughly accurate protocol
definition.
It shares definitions with "provisioner.proto" for simple
interop with provisions!