- Notifications
You must be signed in to change notification settings - Fork1k
feat: Add parameter and jobs database schema#81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This modifies a prior migration which is typically forbidden,but because we're pre-production deployment I felt groupingwould be helpful to future contributors.This adds database functions that are required for the provisionerdaemon and job queue logic.
codecovbot commentedJan 29, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #81 +/- ##==========================================+ Coverage 71.84% 71.87% +0.02%========================================== Files 88 88 Lines 3417 3417 Branches 55 55 ==========================================+ Hits 2455 2456 +1+ Misses 753 752 -1 Partials 209 209
Continue to review full report at Codecov.
|
| UPDATE | ||
| SKIP LOCKED |
bryphe-coderJan 29, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
question (non-blocking): Just curious why this is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll add a comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added the following comment:
-- Acquires the lock for a single job that isn't started, completed,-- cancelled, and that matches an array of provisioner types.---- SKIP LOCKED is used to jump over locked rows. This prevents-- multiple provisioners from acquiring the same jobs. See:-- https://www.postgresql.org/docs/9.5/sql-select.html#SQL-FOR-UPDATE-SHARE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Excellent, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍
This modifies a prior migration which is typically forbidden,
Seems OK while we're marching towards black-triangle, and there is no production deployment at all yet
This modifies a prior migration which is typically forbidden,
but because we're pre-production deployment I felt grouping
would be helpful to future contributors.
This adds database functions that are required for the provisioner
daemon and job queue logic.