- Notifications
You must be signed in to change notification settings - Fork1k
feat: add locked TTL field to template meta#8020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| const ( | ||
| failureTTL=7*24*time.Hour | ||
| inactivityTTL=180*24*time.Hour | ||
| lockedTTL=360*24*time.Hour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
NIT: I think I stuck my tests in thecoderd folder as well - I'm wondering if they should actually live inenterprise/coderd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
probably good to have tests in both
| "max_ttl":ActionTrack, | ||
| "failure_ttl":ActionTrack, | ||
| "inactivity_ttl":ActionTrack, | ||
| "locked_ttl":ActionTrack, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
😸
...ages/TemplateSettingsPage/TemplateSchedulePage/TemplateScheduleForm/TemplateScheduleForm.tsxShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...ages/TemplateSettingsPage/TemplateSchedulePage/TemplateScheduleForm/TemplateScheduleForm.tsxShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| } | ||
| } | ||
| consthandleToggleLockedCleanup=async(e:ChangeEvent)=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
NIT: Since we now have 3 toggling functions, we might be able to refactor into one function that takes two form values, e.g.locked_cleanup_enabled andlocked_ttl_ms and appropriately toggles TTL.
| ttl={form.values.locked_ttl_ms} | ||
| />, | ||
| )} | ||
| disabled={isSubmitting||!form.values.locked_cleanup_enabled} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should this field also be disabled if Inactivity Cleanup is disabled? Not sure that it makes sense to have one without the other, although perhaps we'll have manual locking down the road:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah I think that probably makes sense, we can fix it in a follow up PR.
No description provided.