- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: add login type 'none' to prevent password login#8009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Users with this login type must use tokens to authenticate.Tokens must come from some other source, not a /login with passwordauthentication
deansheather approved these changesJun 13, 2023
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Dean Sheather <dean@deansheather.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#7657
Users with this login type must use tokens to authenticate.
Tokens must come from some other source, not a /login with password
authentication
Cli usage & Output
Future Work
This is the initial work to disable password authentication on a user by user basis. To polish this feature, I believe we need some extra features.
password->none, ornone->oidc. (Allow conversion of email/password authenticated account to OpenID Connect authed account #4505)LoginTypeNonecompletely controllable by the owner/admin that is issuing these tokens. (API Key/Token scopes to prevent creating another api key/token #8011)