- Notifications
You must be signed in to change notification settings - Fork929
chore: fix miscellaneous issues in scaletest scripts#8006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
johnstcn commentedJun 13, 2023
- scaletest.go: actually wait for prometheus metrics regardless of tracing
- coder_workspacetraffic.sh: allow specifying traffic rate
- scaletest.sh: plumb through scaletest traffic options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
| } | ||
| // Wait for prometheus metrics to be scraped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: I'm wondering if there could be an active loop implemented instead to make sure that metrics have been scraped. Nothing is wrong with this submission though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I considered that as well but didn't think it worth the additional complexity.