Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: deduplicate language setup#7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ammario merged 2 commits intomainfromci-split-race
Jun 1, 2023
Merged

ci: deduplicate language setup#7753

ammario merged 2 commits intomainfromci-split-race
Jun 1, 2023

Conversation

ammario
Copy link
Member

@ammarioammario commentedJun 1, 2023•
edited
Loading

Previously, we were duplicating large portions of each job with language setup and caching. This change organizes the boilerplate into reusable, composite actions.

Also, this change splits up thego-psql test intogo-pg andgo-race.go-psql was a misnomer because it also ran the race detector. With the split we can take better advantage of CI concurrency and the workflow should complete faster.

matifali reacted with rocket emoji
@ammarioammario changed the titleci: deduplicate Go actionsci: deduplicate language setupJun 1, 2023
@ammarioammario marked this pull request as ready for reviewJune 1, 2023 07:46
@matifali
Copy link
Member

matifali commentedJun 1, 2023•
edited
Loading

This makes the ci code concise and more maintainable. Awesome job@ammario.

ammario reacted with heart emoji

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Github actions setup LGTM 👍

Screenshot 2023-06-01 at 10 05 23

I guess that this glitch will require admin rights to merge the PR?

@ammario
Copy link
MemberAuthor

@mtojek I just need to update the repo settings before I merge.

mtojek reacted with thumbs up emoji

@ammarioammarioenabled auto-merge (squash)June 1, 2023 08:08
@ammarioammario merged commit555ea64 intomainJun 1, 2023
@ammarioammario deleted the ci-split-race branchJune 1, 2023 08:20
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mtojekmtojekmtojek approved these changes

Assignees

@ammarioammario

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ammario@matifali@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp