NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: Add comment explaining why testpackage is enabled#774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kylecarbs merged 1 commit intomainfromtestpkg

Mar 31, 2022

Merged

chore: Add comment explaining why testpackage is enabled#774

kylecarbs merged 1 commit intomainfromtestpkg

Mar 31, 2022

Conversation

Copy link

Member

kylecarbs commentedMar 31, 2022

A discussion (linked below) was had that touched on why this linter
is enabled. To avoid losing that history, adding the comment inline with
our linting rules can avoid duplicating this discussion!

#741 (comment)

chore: Add comment explaining why testpackage is enabled

8f697af

A discussion (linked below) was had that touched on why this linteris enabled. To avoid losing that history, adding the comment inline withour linting rules can avoid duplicating this discussion!#741 (comment)

kylecarbs requested review fromEmyrk andf0ssel

March 31, 2022 16:49

kylecarbs self-assigned this

Mar 31, 2022

Copy link

codecovbot commentedMar 31, 2022•
edited
Loading

Codecov Report

Merging#774 (8f697af) intomain (bb6c12d) willdecrease coverage by0.06%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main     #774      +/-   ##==========================================- Coverage   63.91%   63.84%   -0.07%==========================================  Files         199      199                Lines       11826    11826                Branches       87       87              ==========================================- Hits         7558     7550       -8- Misses       3442     3449       +7- Partials      826      827       +1

Flag	Coverage Δ
unittest-go-	`62.97% <ø> (-0.19%)`	⬇️
unittest-go-macos-latest	`58.78% <ø> (+<0.01%)`	⬆️
unittest-go-ubuntu-latest	`61.79% <ø> (+0.16%)`	⬆️
unittest-go-windows-2022	`58.03% <ø> (-0.02%)`	⬇️
unittest-js	`62.63% <ø> (ø)`

Impacted Files	Coverage Δ
provisionersdk/transport.go	`78.72% <0.00%> (-6.39%)`	⬇️
cli/cliui/agent.go	`77.19% <0.00%> (-5.27%)`	⬇️
coderd/workspaceresources.go	`54.87% <0.00%> (-2.85%)`	⬇️
peer/channel.go	`83.04% <0.00%> (-0.59%)`	⬇️
peerbroker/proxy.go	`57.55% <0.00%> (-0.59%)`	⬇️
coderd/provisionerdaemons.go	`60.03% <0.00%> (-0.51%)`	⬇️
peer/conn.go	`78.17% <0.00%> (ø)`
provisionerd/provisionerd.go	`79.14% <0.00%> (ø)`
provisioner/echo/serve.go	`56.80% <0.00%> (+2.39%)`	⬆️
peerbroker/dial.go	`83.60% <0.00%> (+6.55%)`	⬆️
... and1 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatebb6c12d...8f697af. Read thecomment docs.