Jun 1, 2023 · May 31, 2023 · May 31, 2023 · May 31, 2023 · May 31, 2023 · May 31, 2023
diff --git a/coderd/database/dbfake/databasefake.go b/coderd/database/dbfake/databasefake.go
 continue
 }

 date := as.CreatedAt.UTC().Add(time.Duration(arg.TzOffset) * time.Hour).Truncate(time.Hour * 24)
 date := as.CreatedAt.UTC().Add(time.Duration(arg.TzOffset) * time.Hour * -1).Truncate(time.Hour * 24)

 dateEntry := seens[date]
 if dateEntry == nil {
 if as.ConnectionCount == 0 {
 continue
 }
 date := as.CreatedAt.UTC().Add(time.Duration(tzOffset) * time.Hour).Truncate(time.Hour * 24)
 date := as.CreatedAt.UTC().Add(time.Duration(tzOffset) *-1 *time.Hour).Truncate(time.Hour * 24)

 dateEntry := seens[date]
 if dateEntry == nil {
diff --git a/coderd/metricscache/metricscache_test.go b/coderd/metricscache/metricscache_test.go
 },
 {
 name:     "tzOffset",
 tzOffset:-1,
 tzOffset: 1,
 args: args{
 rows: []database.InsertWorkspaceAgentStatParams{
 statRow(zebra, dateH(2022, 1, 2, 1)),
 },
 {
 name:     "tzOffsetPreviousDay",
 tzOffset:-6,
 tzOffset: 6,
 args: args{
 rows: []database.InsertWorkspaceAgentStatParams{
 statRow(zebra, dateH(2022, 1, 2, 1)),
diff --git a/site/src/api/api.ts b/site/src/api/api.ts
  return response.data
 }

 export const getDeploymentDAUs = async (): Promise<TypesGen.DAUsResponse> => {
  const response = await axios.get(`/api/v2/insights/daus`)
 export const getDeploymentDAUs = async (
  // Default to user's local timezone
  offset = new Date().getTimezoneOffset() / 60,
 ): Promise<TypesGen.DAUsResponse> => {
  const response = await axios.get(`/api/v2/insights/daus?tz_offset=${offset}`)
  return response.data
 }

diff --git a/site/src/xServices/deploymentConfig/deploymentConfigMachine.ts b/site/src/xServices/deploymentConfig/deploymentConfigMachine.ts
  {
    services: {
      getDeploymentValues: getDeploymentValues,
      getDeploymentDAUs: getDeploymentDAUs,
      getDeploymentDAUs: async () => {
        return getDeploymentDAUs()
      },
    },
    actions: {
      assignDeploymentValues: assign({
Original file line number	Diff line number	Diff line change
Expand Up		@@ -453,7 +453,7 @@ func (q *fakeQuerier) GetTemplateDAUs(_ context.Context, arg database.GetTemplat
		continue
		}

		date := as.CreatedAt.UTC().Add(time.Duration(arg.TzOffset) * time.Hour).Truncate(time.Hour * 24)
		date := as.CreatedAt.UTC().Add(time.Duration(arg.TzOffset) * time.Hour * -1).Truncate(time.Hour * 24)
Copy link Member johnstcnMay 31, 2023• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. 🤔 This change didn't break anything... which means that our unit tests probably aren't checking something that they should. Copy link MemberAuthor EmyrkMay 31, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. You are half right. I forgot to change it in the Dau dbfake function, which does break the unit test. The template test does not break because I reverted the Template DAU to only use`UTC` again for performance reasons. So this is always`0` as the offset. tl;dr fixing it in the spot that is useddoes break the test

		dateEntry := seens[date]
		if dateEntry == nil {
Expand DownExpand Up		@@ -492,7 +492,7 @@ func (q *fakeQuerier) GetDeploymentDAUs(_ context.Context, tzOffset int32) ([]da
		if as.ConnectionCount == 0 {
		continue
		}
		date := as.CreatedAt.UTC().Add(time.Duration(tzOffset) * time.Hour).Truncate(time.Hour * 24)
		date := as.CreatedAt.UTC().Add(time.Duration(tzOffset) -1 time.Hour).Truncate(time.Hour * 24)

		dateEntry := seens[date]
		if dateEntry == nil {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -151,7 +151,7 @@ func TestCache_TemplateUsers(t *testing.T) {
		},
		{
		name: "tzOffset",
		tzOffset:-1,
		tzOffset: 1,
		args: args{
		rows: []database.InsertWorkspaceAgentStatParams{
		statRow(zebra, dateH(2022, 1, 2, 1)),
Expand DownExpand Up		@@ -180,7 +180,7 @@ func TestCache_TemplateUsers(t *testing.T) {
		},
		{
		name: "tzOffsetPreviousDay",
		tzOffset:-6,
		tzOffset: 6,
		args: args{
		rows: []database.InsertWorkspaceAgentStatParams{
		statRow(zebra, dateH(2022, 1, 2, 1)),
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -831,8 +831,11 @@ export const getTemplateDAUs = async (
		return response.data
		}

		export const getDeploymentDAUs = async (): Promise<TypesGen.DAUsResponse> => {
		const response = await axios.get(`/api/v2/insights/daus`)
		export const getDeploymentDAUs = async (
		// Default to user's local timezone
		offset = new Date().getTimezoneOffset() / 60,
		): Promise<TypesGen.DAUsResponse> => {
		const response = await axios.get(`/api/v2/insights/daus?tz_offset=${offset}`)
		return response.data
		}

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -64,7 +64,9 @@ export const deploymentConfigMachine = createMachine(
		{
		services: {
		getDeploymentValues: getDeploymentValues,
		getDeploymentDAUs: getDeploymentDAUs,
		getDeploymentDAUs: async () => {
		return getDeploymentDAUs()
		},
		},
		actions: {
		assignDeploymentValues: assign({
Expand Down