Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add support for insiders channel to "VS Code Desktop" button#7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 7 commits intomainfromfeat/issue-6267/add-vscode-insiders
May 31, 2023

Conversation

matifali
Copy link
Member

@matifalimatifali commentedMay 31, 2023•
edited
Loading

Resolves#6267

@matifalimatifali removed this from the🧹 Sprint 0 milestoneMay 31, 2023
@matifalimatifali requested review fromBrunoQuaresma,bpmct andkylecarbs and removed request forBrunoQuaresmaMay 31, 2023 12:54
@matifalimatifali changed the titlefeat: support VS Code Insidersfeat: add support for insiders channel to "VS Code Desktop" buttonMay 31, 2023
@BrunoQuaresmaBrunoQuaresmaforce-pushed thefeat/issue-6267/add-vscode-insiders branch froma2a65de toe596f3aCompareMay 31, 2023 14:18
@BrunoQuaresma
Copy link
Collaborator

Changes:

  • I extracted each variant to its own component. Even having some duplication I think it is just easier for now if we want to remove or add one more option. Duplication is not always bad 😃
  • I used a few components from MUI to make it look more "natural" like the ButtonGroup and Menu
  • The problem with the SVG was the "id" conflicts 😅 this one is very annoying

Demo:

Screen.Recording.2023-05-31.at.11.15.05.mov

@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 31, 2023
@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)May 31, 2023 16:26
@BrunoQuaresmaBrunoQuaresma merged commitb80756e intomainMay 31, 2023
@BrunoQuaresmaBrunoQuaresma deleted the feat/issue-6267/add-vscode-insiders branchMay 31, 2023 16:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@bpmctbpmctAwaiting requested review from bpmct

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support multiple vs code channels for "VS Code Desktop" button

2 participants

@matifali@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp