Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: Limit scopes with semantic#773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromscopes
Mar 31, 2022
Merged

ci: Limit scopes with semantic#773

kylecarbs merged 1 commit intomainfromscopes
Mar 31, 2022

Conversation

kylecarbs
Copy link
Member

This should enfore a standardized commit message without a scope.

The repository isn't complex enough to require scopes yet, so we
can punt this down the road!

This should enfore a standardized commit message without a scope.The repository isn't complex enough to require scopes yet, so wecan punt this down the road!
@kylecarbskylecarbs self-assigned thisMar 31, 2022
@codecov
Copy link

codecovbot commentedMar 31, 2022
edited
Loading

Codecov Report

Merging#773 (cc0fb62) intomain (f5757ff) willincrease coverage by0.00%.
The diff coverage isn/a.

@@           Coverage Diff           @@##             main     #773   +/-   ##=======================================  Coverage   63.95%   63.96%           =======================================  Files         199      199             Lines       11826    11826             Branches       87       87           =======================================+ Hits         7563     7564    +1+ Misses       3437     3436    -1  Partials      826      826
FlagCoverage Δ
unittest-go-63.11% <ø> (-0.03%)⬇️
unittest-go-macos-latest58.96% <ø> (+0.09%)⬆️
unittest-go-ubuntu-latest61.57% <ø> (-0.21%)⬇️
unittest-go-windows-202258.07% <ø> (+0.03%)⬆️
unittest-js62.63% <ø> (ø)
Impacted FilesCoverage Δ
cli/cliui/agent.go77.19% <0.00%> (-5.27%)⬇️
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
peer/conn.go76.90% <0.00%> (-2.04%)⬇️
coderd/workspaceresources.go56.09% <0.00%> (-1.63%)⬇️
peerbroker/proxy.go57.55% <0.00%> (-0.59%)⬇️
provisionerd/provisionerd.go80.61% <0.00%> (+0.44%)⬆️
coderd/provisionerdaemons.go60.03% <0.00%> (+0.50%)⬆️
provisioner/echo/serve.go59.20% <0.00%> (+4.80%)⬆️
pty/start_other.go88.23% <0.00%> (+23.52%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef5757ff...cc0fb62. Read thecomment docs.

@kylecarbskylecarbs merged commit1b43a4a intomainMar 31, 2022
@kylecarbskylecarbs deleted the scopes branchMarch 31, 2022 15:41
Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me - happy to help flesh those out down the line as someone that looked after this in v1

kylecarbs reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled left review comments

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@johnstcn@greyscaled

[8]ページ先頭

©2009-2025 Movatter.jp