Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: stream provisioner logs#7712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 3 commits intomainfromspike/7371-stream-provisioner-logs
May 31, 2023

Conversation

spikecurtis
Copy link
Contributor

fixes#7371

now that the pubsub gives in-order messages, and reports errors we can greatly simplify our code for streaming provisioner logs. We query for any historical logs, then wait for a kick from the pubsub to query for new logs or end the stream.

One other change while I was in this code is to switch the websocket to use the underlying message-oriented API for sending our JSON-encoded logs. This requires less processing (rather than running a byte stream over websocket message frames), and the Javascript clients assume that an entire log object is in a single frame, which is something we don't strictly guarantee in the old code, so it's less fragile.

Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm unsure about the guarantee of postgres subscriptions being active immediately when subscribing but I'm sure you've explored it to know it's reliable.

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtisspikecurtisenabled auto-merge (squash)May 31, 2023 06:07
@spikecurtisspikecurtis merged commit7c3dbbb intomainMay 31, 2023
@spikecurtisspikecurtis deleted the spike/7371-stream-provisioner-logs branchMay 31, 2023 06:16
ammario pushed a commit that referenced this pull requestJun 1, 2023
* stream provisioner logsSigned-off-by: Spike Curtis <spike@coder.com>* Fix importsSigned-off-by: Spike Curtis <spike@coder.com>* Better logging, naming, arg orderSigned-off-by: Spike Curtis <spike@coder.com>---------Signed-off-by: Spike Curtis <spike@coder.com>
ammario pushed a commit to goodspark/coder that referenced this pull requestJun 1, 2023
* stream provisioner logsSigned-off-by: Spike Curtis <spike@coder.com>* Fix importsSigned-off-by: Spike Curtis <spike@coder.com>* Better logging, naming, arg orderSigned-off-by: Spike Curtis <spike@coder.com>---------Signed-off-by: Spike Curtis <spike@coder.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@mafredrimafredriAwaiting requested review from mafredri

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression: querying logs while job is running can miss some
2 participants
@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp