- Notifications
You must be signed in to change notification settings - Fork952
fix: stream provisioner logs#7712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm unsure about the guarantee of postgres subscriptions being active immediately when subscribing but I'm sure you've explored it to know it's reliable.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Spike Curtis <spike@coder.com>
* stream provisioner logsSigned-off-by: Spike Curtis <spike@coder.com>* Fix importsSigned-off-by: Spike Curtis <spike@coder.com>* Better logging, naming, arg orderSigned-off-by: Spike Curtis <spike@coder.com>---------Signed-off-by: Spike Curtis <spike@coder.com>
* stream provisioner logsSigned-off-by: Spike Curtis <spike@coder.com>* Fix importsSigned-off-by: Spike Curtis <spike@coder.com>* Better logging, naming, arg orderSigned-off-by: Spike Curtis <spike@coder.com>---------Signed-off-by: Spike Curtis <spike@coder.com>
fixes#7371
now that the pubsub gives in-order messages, and reports errors we can greatly simplify our code for streaming provisioner logs. We query for any historical logs, then wait for a kick from the pubsub to query for new logs or end the stream.
One other change while I was in this code is to switch the websocket to use the underlying message-oriented API for sending our JSON-encoded logs. This requires less processing (rather than running a byte stream over websocket message frames), and the Javascript clients assume that an entire log object is in a single frame, which is something we don't strictly guarantee in the old code, so it's less fragile.