- Notifications
You must be signed in to change notification settings - Fork1k
chore: improve postgres test time by removing cleanup#7522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
We don't need to delete databases on cleanup... and we don't need toalways run without a cache either!
| -covermode=atomic -coverprofile="gotests.coverage" -timeout=20m\ | ||
| -parallel=4\ | ||
| -coverpkg=./...\ | ||
| -count=1 -race -failfast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why remove? I think it forces go test to not skip cached tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Go test caching is pretty effective in reducing only duplicates, we use it for the other jobs
| return"postgres://postgres:postgres@127.0.0.1:5432/"+dbName+"?sslmode=disable",func() { | ||
| // We don't need to clean anything up here... it's just a database in a container, | ||
| // so cleaning up the container will clean up the database. | ||
| },nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is this func only used in ci? would be nice if this only applied in ci so we don't disable cleanup in dogfood.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nah, it's used outside too. We just don't need to clean this because it isn't actual waste
We don't need to delete databases on cleanup... and we don't need to always run without a cache either!