May 22, 2023 · May 11, 2023 · May 12, 2023 · May 12, 2023 · May 12, 2023 · May 12, 2023
diff --git a/site/src/contexts/ProxyContext.tsx b/site/src/contexts/ProxyContext.tsx
    setProxy(
      getPreferredProxy(
        proxiesResp?.regions ?? [],
        // For some reason if I use 'userSavedProxy' here,
        // the tests fail. It does not load "undefined" after a
        // clear, but takes the previous value.
        loadUserSelectedProxy(),
        proxyLatencies,
      ),
Original file line number	Diff line number	Diff line change
Expand Up		@@ -111,9 +111,6 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
		setProxy(
		getPreferredProxy(
		proxiesResp?.regions ?? [],
		// For some reason if I use 'userSavedProxy' here,
		// the tests fail. It does not load "undefined" after a
		// clear, but takes the previous value.
		loadUserSelectedProxy(),
Copy link Member Kira-PilotMay 15, 2023• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. `setState`s are async - when you set a value, it isn't set instantly. So`userSavedProxy` may not be updated by the time you try to grab it here. That is probably why you're seeing the previous value. On top of that, there's a possibility we might be overwriting what the user is trying to set in localStorage by resetting to an older value onln 110. Copy link MemberAuthor EmyrkMay 18, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I tried adding an`await setUserSaveProxy` and still had this behavior. Ln 110 only loads from local storage, it does not do any writes. Copy link Member Kira-PilotMay 18, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. My bad about ln 110 - was confusing`setUserSavedProxy` and`saveUserSelectedProxy` as mentioned above. Regarding your`await`: you can't await a`setState` because, although asynchronous, it doesn't return a promise. You could write a callback but I think what you have here is best. Do you mind removing the comment? I think this is expected behavior. Emyrk reacted with thumbs up emoji
		proxyLatencies,
		),
Expand Down