Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add deleted_at field to workspace model#7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 5 commits intomainfromworkspace-impending-deletion/kira-pilot
May 11, 2023

Conversation

Kira-Pilot
Copy link
Member

@Kira-PilotKira-Pilot commentedMay 9, 2023
edited by sreya
Loading

Screenshot 2023-05-09 at 5 36 13 PM

deleted_at is a calculated field on theworkspace model that will return atime.Time if a workspace is scheduled for deletion. Workspaces are scheduled for deletion when the template'sinactivity_ttl is set (when it's not 0) and when the workspace hasn't seen activity in the last day.

We will use this field to display notifications on the FE about upcoming workspace deletion.

@sreyasreya changed the titlefeat: add impending_deletion field to workspace modelfeat: add deleted_at field to workspace modelMay 10, 2023
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Double checked the duration nano vs ms. All good!

Kira-Pilot reacted with heart emoji
@Kira-PilotKira-Pilot merged commitae3473d intomainMay 11, 2023
@Kira-PilotKira-Pilot deleted the workspace-impending-deletion/kira-pilot branchMay 11, 2023 15:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@sreyasreyaAwaiting requested review from sreya

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@Kira-PilotKira-Pilot

Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
@Kira-Pilot@Emyrk@bpmct

[8]ページ先頭

©2009-2025 Movatter.jp